[Type] Mat: Fix {add,sub}Transposed() self-aliasing calls - #6276
Open
fredroy wants to merge 2 commits into
Open
Conversation
fredroy
added
pr: fix
Contributor
Author
|
[ci-build][with-all-tests] |
bakpaul
requested changes
Sep 1, 2026
| (*this)(i,j) = sum; | ||
| (*this)(j,i) = sum; | ||
| } | ||
| (*this)(i,i) += (*this)(i,i); |
Contributor
There was a problem hiding this comment.
I would put this before the for loop for cache purpose. Same for subTranspose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #6274
and #6275
All-in-one PR this time, as addTransposed() and subTransposed() are barely used (at least not in the main codebase anyway)
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if