Supervise delayed job promotion - #11
Open
jbaxendale-ut wants to merge 1 commit into
Open
Conversation
A transient Redis error can terminate the promotion loop and leave due jobs unprocessed until the server restarts. Redis script-cache eviction is one occurrence of this failure. Keep the promoter running with bounded exponential backoff, reload the move script after NOSCRIPT, and expose application-neutral failure and recovery instrumentation. This lets any Redis-backed AsyncJob deployment restore scheduled work automatically and surface outages without a monitoring-service dependency. Signed-off-by: Jeff Baxendale <jbaxendale@usertesting.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transient Redis failure could terminate the delayed-job promotion loop, leaving scheduled jobs unprocessed until the server restarted. Redis script-cache eviction (
NOSCRIPT) is one concrete example.Disclaimer: developed with the help of Codex as I was investigating latency issues in an LLM-moderated interview flow in our application. Let me know if this seems in appropriate, but wanted to offer my changes (running in production now) upstream see also socketry/async-job-adapter-active_job#29
Keeps the promoter alive with bounded exponential backoff, reloads the Lua script after
NOSCRIPT, and provides optional, application-neutral failure and recovery instrumentation with configurable timings.Types of Changes
Contribution