Add participantChannel to isolate keeping count of participants#408
Open
doodlesbykumbi wants to merge 2 commits intosocketio:masterfrom
Open
Add participantChannel to isolate keeping count of participants#408doodlesbykumbi wants to merge 2 commits intosocketio:masterfrom
doodlesbykumbi wants to merge 2 commits intosocketio:masterfrom
Conversation
participantChannel is a special channel used only to keep track of participants. No data goes through it. This prevents bugs associated with having non-participating subscribers on the channels that have data going through them.
The participant channel is used to count subscribers. Any counted but non-participating subscribers result in a timeout error when gathering responses. Non-participating clients can subscriber to the request and response channels without issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #406
participantChannel is a special channel used only to keep track of participants. No data goes through it. This prevents bugs associated with having non-participating subscribers on the channels that have data going through them.