fix: make sure to add / prefix to the namespace name#1574
Open
karagenc wants to merge 1 commit intosocketio:mainfrom
Open
fix: make sure to add / prefix to the namespace name#1574karagenc wants to merge 1 commit intosocketio:mainfrom
/ prefix to the namespace name#1574karagenc wants to merge 1 commit intosocketio:mainfrom
Conversation
/ prefix to namespace name
/ prefix to namespace name/ prefix to the namespace name
Ionys320
approved these changes
Jan 25, 2024
Ionys320
left a comment
There was a problem hiding this comment.
I guess nsp can't be another thing than a string, so it sounds good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
Trying to connect to a namespace without the slash prefix ends up with a decoder error (error occurs on the server side):
Client code
Server code
New behaviour
Slash automatically gets inserted as a prefix inside the
Manager.socketfunction.