chore: bump snyk-ls to 65f506fd, gaf to v1.0.0 [IDE-1896] - #7071
Open
nick-y-snyk wants to merge 2 commits into
Open
chore: bump snyk-ls to 65f506fd, gaf to v1.0.0 [IDE-1896]#7071nick-y-snyk wants to merge 2 commits into
nick-y-snyk wants to merge 2 commits into
Conversation
Pulls in snyk-ls PR #1381, which switches audience-host validation to GAF's IsValidSnykHost (domain-allowlist based) instead of the superseded regex. GAF bump to v1.0.0 comes along transitively since snyk-ls now requires it directly.
|
|
|
| Status | Scan Engine |  Critical |
 High |
 Medium |
 Low |
Total (0) |
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details | |
| Licenses | 0 | 0 | 0 | 0 | See details | |
| ✅ | Code Security | 0 | 0 | 0 | 0 | 0 issues |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
Author
|
Reopening to retrigger checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps
github.com/snyk/snyk-lsto the merge commit of snyk-ls#1381, andgithub.com/snyk/go-application-frameworkto v1.0.0 (pulled in transitively — snyk-ls now requires it directly).snyk-ls#1381 switches the language server's audience-host validation (
extractAudHost/audHostFromClaiminauth_service_impl.go) from the supersededCONFIG_KEY_ALLOWED_HOST_REGEXPregex check to GAF'sIsValidSnykHost(domain-allowlist based), matching the same migration GAF PR #662 made tomodifyTokenUrl.cli itself doesn't call the affected auth-host functions directly, so this is a pure dependency bump — no cli-side code change.
Jira: IDE-1896
Checklist
go build ./...clean in bothcliv2andcliv2-privatego vet ./...clean in both modulesgo test ./...passes incliv2(all packages)