Conversation
Author
|
I think unit tests were broken a long time ago. |
Author
|
I have just commented out the bad unit test. I'm not sure what is going on there with arm 32-bit. |
sergio-nsk
requested changes
Jul 10, 2025
Comment on lines
+283
to
+288
| DWORD unwind_rva; | ||
| #if defined(_M_ARM64) || defined(__aarch64__) | ||
| unwind_rva = funcs[i].UnwindData; | ||
| #else | ||
| unwind_rva = funcs[i].UnwindInfoAddress; | ||
| #endif |
There was a problem hiding this comment.
This would make a less change and unlikely conflicts with future upstream updates,
Suggested change
| DWORD unwind_rva; | |
| #if defined(_M_ARM64) || defined(__aarch64__) | |
| unwind_rva = funcs[i].UnwindData; | |
| #else | |
| unwind_rva = funcs[i].UnwindInfoAddress; | |
| #endif | |
| #if defined(_M_ARM64) || defined(__aarch64__) | |
| DWORD unwind_rva unwind_rva = funcs[i].UnwindData; | |
| #else | |
| DWORD unwind_rva unwind_rva = funcs[i].UnwindInfoAddress; | |
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://chromium-review.googlesource.com/c/breakpad/breakpad/+/6719700