Skip to content

fix: quote recursive union member annotations #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alan4506 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: quote recursive union member annotations #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2f14b0
fix: quote recursive union member annotations
Alan4506 Jun 2, 2026
398548f
Bump codegen patch version
Alan4506 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codegen/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@

allprojects {
group = "software.amazon.smithy.python"
version = "0.3.0"
version = "0.3.1"
}
5 changes: 4 additions & 1 deletion ...n/core/src/main/java/software/amazon/smithy/python/codegen/generators/UnionGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,14 @@ public void run() {

var target = model.expectShape(member.getTarget());
var targetSymbol = symbolProvider.toSymbol(target);
writer.pushState();
writer.putContext("quote", recursiveShapes.contains(target) ? "'" : "");
writer.write("""
@dataclass
class $1L:
${2C|}

value: $3T
value: ${quote:L}$3T${quote:L}

def serialize(self, serializer: ShapeSerializer):
serializer.write_struct($4T, self)
Expand All @@ -92,6 +94,7 @@ def deserialize(cls, deserializer: ShapeDeserializer) -> Self:
new MemberDeserializerGenerator(context, w, member, "deserializer")))

);
writer.popState();
}

// Note that the unknown variant doesn't implement __eq__. This is because
Expand Down
Loading