Skip to content

Follow the CCIP v2 redirect in linkcheck - #4266

Open
thodges-gh wants to merge 2 commits into
mainfrom
fix/linkcheck-ccip-v2-remap
Open

thodges-gh wants to merge 2 commits into
mainfrom
fix/linkcheck-ccip-v2-remap

Conversation

@thodges-gh

Copy link
Copy Markdown
Contributor

linkcheck-internal runs lychee 0.24.2 with offline = true over .vercel/output/static. A link to /ccip/v2/evm/getting-started failed because no static file exists at that path, while /ccip/evm/getting-started passed. Both URLs are correct on the live site: vercel.json returns 301 from /ccip/v2 and /ccip/v2/:path* to /ccip and /ccip/:path*.

This PR adds lychee remap rules that mirror those two redirects, so the checker resolves the v2 links the way a browser would. A missing page and a missing anchor still fail, and /ccip/v1 and /ccip/v20 are not rewritten.

The query rule is "/ccip/v2\\? /ccip?". The ? is escaped, because an unescaped ? is a regex quantifier: that form rewrote /ccip/v1/... into /ccip?1/..., and the full site check reported 21518 errors.

.github/workflows/test.yml gains lychee.toml, vercel.json, and src/scripts/link-check/** in the content path filter so this check runs when the checker changes, plus a step that checks the pass fixture before Build Site.

@thodges-gh
thodges-gh requested review from a team as code owners October 2, 2026 20:31
@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
documentation Ready Ready Preview Oct 2, 2026 10:28pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

👋 thodges-gh, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

vercel.json 301-redirects /ccip/v2 and /ccip/v2/:path* to /ccip and /ccip/:path*, so those links are valid on the live site but have no file in the static build. Add lychee remap rules for the redirect, with a fixture and checker that keep a missing page or anchor failing and leave /ccip/v1 and /ccip/v20 untouched.

This branch was successfully deployed

1 active deployment
Preview — d27ab561 Deployed Oct 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant