Skip to content

fix(ci): cherry-pick #23431 — unify should-run gates - #23432

Open
HashWrangler wants to merge 1 commit into
release/2.60.0from
ci/cherry-pick-23431-2.60.0
Open

fix(ci): cherry-pick #23431 — unify should-run gates#23432
HashWrangler wants to merge 1 commit into
release/2.60.0from
ci/cherry-pick-23431-2.60.0

Conversation

@HashWrangler

Copy link
Copy Markdown
Collaborator

Cherry-picks eaec72e14d (#23431, by @adam-hamrick) onto release/2.60.0 so tag pushes build their CRE test image.

Why

Tags cut from release/2.60.0 currently fail the same way v2.59.0-beta.0 did — run 30938527720, all 34 Core CRE E2E jobs dead in Start local CRE with:

manifest for .../chainlink-integration-tests:738ebda... not found: manifest unknown

run-core-cre-e2e-tests-setup sets should-run=true on a push when ref_type == 'tag', but build-chainlink's any-should-run had no tag clause — only workflow_dispatch, the changes.* path filters, and the e2e label. On a tag push the tagged commit is "Bump version and update CHANGELOG", so every path filter is false, the build is skipped, and the tests run anyway against an image that was never pushed. build-chainlink still reports success because its steps are if:-skipped, so the needs on it is satisfied.

#23431 fixes this on develop by making the build gate consume the setup jobs' should-run outputs, so there is a single decision instead of two that can drift.

develop has the fix; release/2.60.0 does not. pull_request runs use the merge ref and already pick it up — this cherry-pick is specifically for tag pushes, which read the workflow from the release branch.

Notes

  • Applies cleanly, no conflicts. Diff is byte-identical to develop's.
  • Original authorship preserved (Adam Hamrick).
  • Verified on this branch: no dangling needs.changes references remain in build-chainlink, YAML parses, and both setup jobs still needs: [changes, labels] so the ordering chain holds.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting release/2.60.0

@trunk-io

trunk-io Bot commented Aug 17, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants