fix(ci): cherry-pick #23431 — unify should-run gates - #23432
Open
HashWrangler wants to merge 1 commit into
Open
Conversation
product-security-plaid-production
Bot
requested review from
kalverra and
tvc-robsondebraga
August 17, 2026 21:44
Contributor
|
✅ No conflicts with other open PRs targeting |
kalverra
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks
eaec72e14d(#23431, by @adam-hamrick) ontorelease/2.60.0so tag pushes build their CRE test image.Why
Tags cut from
release/2.60.0currently fail the same wayv2.59.0-beta.0did — run 30938527720, all 34 Core CRE E2E jobs dead in Start local CRE with:run-core-cre-e2e-tests-setupsetsshould-run=trueon a push whenref_type == 'tag', butbuild-chainlink'sany-should-runhad no tag clause — onlyworkflow_dispatch, thechanges.*path filters, and the e2e label. On a tag push the tagged commit is "Bump version and update CHANGELOG", so every path filter is false, the build is skipped, and the tests run anyway against an image that was never pushed.build-chainlinkstill reports success because its steps areif:-skipped, so theneedson it is satisfied.#23431 fixes this on
developby making the build gate consume the setup jobs'should-runoutputs, so there is a single decision instead of two that can drift.develophas the fix;release/2.60.0does not.pull_requestruns use the merge ref and already pick it up — this cherry-pick is specifically for tag pushes, which read the workflow from the release branch.Notes
needs.changesreferences remain inbuild-chainlink, YAML parses, and both setup jobs stillneeds: [changes, labels]so the ordering chain holds.