Skip to content

[CRE-2556] Improve connection between node and gateway - #23428

Merged
bolekk merged 4 commits into
developfrom
CRE-INCIDENT-2556
Aug 18, 2026
Merged

[CRE-2556] Improve connection between node and gateway#23428
bolekk merged 4 commits into
developfrom
CRE-INCIDENT-2556

Conversation

@agparadiso

@agparadiso agparadiso commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Description

This pr contains two improvements:

  • The keepalive loop was a single routine for every node, in case of one node down, the loop would get stuck. This translates to seeing the platform_gateway_keepalive_pings_sent_total metric drop for all nodes when in reality only one may be down. This change will help diagnose quicker these kind of issues
  • AuthTimestampToleranceSec default to 5. Under network instability scenarios, the handshake between node and gateway might take more than 1 second. Having 0 as default means this has to happen on the same second. This config change gives the node a bit more time to re-connect and can decrease a 1hr incident to seconds by allowing the reconnection to succeed.

CRE-2556

Requires

Supports

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@agparadiso
agparadiso marked this pull request as ready for review August 17, 2026 18:31
@agparadiso
agparadiso requested review from a team as code owners August 17, 2026 18:31
@trunk-io

trunk-io Bot commented Aug 17, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Comment thread core/services/gateway/connector/config.go Outdated
Comment thread core/services/gateway/connector/config.go Outdated
@agparadiso
agparadiso requested a review from bolekk August 17, 2026 20:53
@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@cl-sonarqube-production

Copy link
Copy Markdown

@agparadiso
agparadiso enabled auto-merge August 18, 2026 19:08
@agparadiso
agparadiso added this pull request to the merge queue Aug 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 18, 2026
@bolekk
bolekk added this pull request to the merge queue Aug 18, 2026
Merged via the queue into develop with commit f322968 Aug 18, 2026
219 checks passed
@bolekk
bolekk deleted the CRE-INCIDENT-2556 branch August 18, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants