core/utils: accept json.Number in ToDecimal - #23427
Open
riba2534 wants to merge 1 commit into
Open
Conversation
ETHABIEncode converts integer ABI values through ToDecimal. JSON unmarshalling yields json.Number for numeric tokens, so encoding uint256[] (and other integer types) failed with: type json.Number cannot be converted to decimal.Decimal Handle json.Number the same way as numeric strings. Fixes smartcontractkit#8504
product-security-plaid-production
Bot
requested review from
chudilka1,
dhaidashenko and
pavel-raykov
August 17, 2026 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8504
Description
ETHABIEncodeconverts integer ABI values (including each element ofuint256[]) throughconvertToETHABIInteger→utils.ToDecimal. JSON unmarshalling producesjson.Numberfor numeric tokens, andToDecimalpreviously rejected that type with:This matches the job-run failure in #8504 (
ETHABIEncodeof auint256[]from JSON numbers).Changes
json.Numberinutils.ToDecimal(same conversion as a numeric string).json.Numberinputs.uint256[]from[]json.Numbersucceeds and matches theint64encoding.Requires
None.
Supports
None.
Test plan
go test ./core/utils -count=1go test ./core/services/pipeline -count=1 -run 'TestETHABIEncode'