Skip to content

[CRE] Sharding support in HTTP gateway handler - #23400

Draft
bolekk wants to merge 1 commit into
developfrom
http_shards
Draft

[CRE] Sharding support in HTTP gateway handler#23400
bolekk wants to merge 1 commit into
developfrom
http_shards

Conversation

@bolekk

@bolekk bolekk commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

HTTP Trigger now understands workflows assigned to multiple shards (e.g. primary + backup). Workflow registration is handled per-shard. Incoming trigger requests are routed to all shards the workflow is assigned to.

HTTP action doesn't need any shard-related changes.

Two main files changed by the PR:

  1. http_trigger_handler.go: support per-shard fan-out and response aggregation.
  2. workflow_metadata_handler.go: support per-shard workflow/sender allowlisting

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Aug 13, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestHttpTriggerHandler_HandleUserTriggerRequest_JWTAuthorization/successful_JWT_authorization The test failed because the workflow was not assigned to any shards, causing an unexpected error. Logs ↗︎
TestHttpTriggerHandler_ReapExpiredCallbacks/keep_non-expired_callbacks The test failed because it received an unexpected error indicating that the workflow is not assigned to any shards. Logs ↗︎
TestHttpTriggerHandler_HandleNodeTriggerResponse/successful_aggregation Logs ↗︎
TestHttpTriggerHandler_HandleUserTriggerRequest_Validation Logs ↗︎

... and 25 more

View Full Report ↗︎Docs

@bolekk
bolekk force-pushed the http_shards branch 3 times, most recently from 607dc04 to a82a9d3 Compare August 18, 2026 03:10
@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants