[CRE-491] Use moved mercury config.#22594
Merged
Merged
Conversation
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
d031780 to
e98d25b
Compare
|
Atrax1
approved these changes
May 22, 2026
george-dorin
approved these changes
May 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: HIGH — This PR changes a core configuration interface (Mercury) and threads the new type through multiple services/modules, coupled with a dependency bump that must align with an external upstream PR.
Changes:
- Bump
github.com/smartcontractkit/chainlink-data-streamstov0.1.15-0.20260522094612-5f9f748bd87aacross root/deployment/scripts/system/integration test modules and plugin manifest. - Migrate
Mercuryconfig interface usage fromcore/configtochainlink-data-streams/llo/transmitter/de. - Remove
core/config/mercury_config.go(old Mercury config interface definitions) and update consumers/mocks accordingly.
Areas requiring scrupulous human review:
- All wiring points that pass
cfg.Mercury()into relayers/registries/delegates (ensure the newde.Mercuryinterface exactly matches expectations of downstream users and that no runtime assumptions changed). core/services/relay/evmMercury transmitter configuration flow (interface boundary changes + dependency bump can silently alter behavior).- Ensure the required upstream PR (chainlink-data-streams#241) is merged and that the referenced pseudo-version contains the moved config API.
Reviewed changes
Copilot reviewed 18 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| system-tests/tests/go.sum | Updates chainlink-data-streams checksum for system test module. |
| system-tests/tests/go.mod | Bumps indirect chainlink-data-streams dependency for system test module. |
| system-tests/lib/go.sum | Updates chainlink-data-streams checksum for system test lib module. |
| system-tests/lib/go.mod | Bumps indirect chainlink-data-streams dependency for system test lib module. |
| plugins/plugins.public.yaml | Updates streams plugin gitRef to the new chainlink-data-streams version. |
| plugins/loop_registry.go | Switches registry Mercury config type from core/config to de.Mercury. |
| plugins/loop_registry_test.go | Updates Mercury config mocks to use llo/transmitter/de interfaces. |
| plugins/cmd/chainlink-evm/main.go | Updates Mercury transmitter config interface usage to llo/transmitter/de. |
| integration-tests/load/go.sum | Updates chainlink-data-streams checksum for load tests module. |
| integration-tests/load/go.mod | Bumps indirect chainlink-data-streams dependency for load tests module. |
| integration-tests/go.sum | Updates chainlink-data-streams checksum for integration tests module. |
| integration-tests/go.mod | Bumps indirect chainlink-data-streams dependency for integration tests module. |
| go.sum | Updates root module chainlink-data-streams checksum. |
| go.mod | Bumps root module chainlink-data-streams dependency. |
| deployment/go.sum | Updates chainlink-data-streams checksum for deployment module. |
| deployment/go.mod | Bumps chainlink-data-streams dependency for deployment module. |
| core/services/relay/evm/evm.go | Points Mercury transmitter config types to llo/transmitter/de. |
| core/services/ocr2/delegate.go | Updates delegate config Mercury type and related interfaces to de.*. |
| core/services/chainlink/relayer_factory.go | Updates factory config to accept de.Mercury via llo/transmitter/de. |
| core/services/chainlink/mocks/general_config.go | Updates generated mock method signatures/returns for Mercury to de.Mercury. |
| core/services/chainlink/config_mercury.go | Updates Mercury config adapters to implement llo/transmitter/de interfaces. |
| core/services/chainlink/config_general.go | Updates Mercury() to return de.Mercury. |
| core/scripts/go.sum | Updates chainlink-data-streams checksum for scripts module. |
| core/scripts/go.mod | Bumps chainlink-data-streams dependency for scripts module. |
| core/config/mercury_config.go | Removes old Mercury config interfaces from core/config. |
| core/config/app_config.go | Updates AppConfig.Mercury() to return de.Mercury. |
Files not reviewed (1)
- core/services/chainlink/mocks/general_config.go: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Requires smartcontractkit/chainlink-data-streams#241