[CRE-491] Use moved llo types from chainlink-data-streams

[pavel-raykov]

Requires smartcontractkit/chainlink-data-streams#239

[github-actions]

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[Copilot]

Pull request overview

Risk Rating: MEDIUM — This PR shifts core LLO/Mercury components (protocol types, transmitter/retirement/cache wiring) from in-repo implementations to chainlink-data-streams, plus broad dependency bumps across multiple Go modules.

Scrupulous human review needed (high-impact areas):

• core/services/relay/evm/llo_provider.go: construction of Mercury/LLO transmitters and DB ORM usage now sourced from chainlink-data-streams (verify DB schema/ORM compatibility and runtime behavior).
• core/config/mercury_config.go + core/config/toml/types.go: protocol type moved; ensure config decoding/validation behavior (e.g., text unmarshalling) remains correct.
• Removed packages under core/services/llo/{mercurytransmitter,retirement,cre,bm}: confirm no missing functionality/regression and that operational metrics/health semantics are preserved by the moved implementations.

Changes:

• Bump chainlink-data-streams to v0.1.15-... and update plugin registry gitRef to match.
• Replace in-repo LLO transmitter/retirement/mercury transmitter/CRE implementations with imports from chainlink-data-streams.
• Update multiple module go.mod files due to dependency graph changes.

Reviewed changes

Copilot reviewed 54 out of 61 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
system-tests/tests/go.mod	Dependency bumps (incl. chainlink-data-streams version) for system tests module.
integration-tests/go.mod	Dependency bumps (incl. chainlink-data-streams version) for integration tests module.
integration-tests/load/go.mod	Dependency bumps (incl. chainlink-data-streams version) for load tests module.
deployment/go.mod	Adds/bumps deps to align deployment tooling with new chainlink-data-streams usage.
go.mod	Root module bumps chainlink-data-streams and various transitive deps after migration.
plugins/plugins.public.yaml	Updates streams plugin gitRef to the new chainlink-data-streams version.
plugins/loop_registry_test.go	Switches Mercury protocol type import to chainlink-data-streams/mercury/transmitter.
plugins/cmd/chainlink-evm/main.go	Uses moved llo/retirement + Mercury protocol type from chainlink-data-streams.
deployment/utils/nodetestutils/node.go	Switches retirement cache import to chainlink-data-streams/llo/retirement.
core/services/relay/evm/llo_provider.go	Uses moved LLO bm/retirement/transmitter + Mercury transmitter protocol/ORM from chainlink-data-streams.
core/services/relay/evm/evm.go	Switches retirement cache import to chainlink-data-streams/llo/retirement.
core/services/relay/dummy/relayer.go	Uses moved bm + retirement helpers from chainlink-data-streams.
core/services/ocr2/plugins/llo/integration_test.go	Updates Mercury protocol type import (but currently sets it incorrectly—see PR comments).
core/services/ocr2/delegate.go	Switches retirement cache import to chainlink-data-streams/llo/retirement.
core/services/llo/delegate.go	Switches retirement cache + transmitter notifier types to chainlink-data-streams.
core/services/llo/report_codecs.go	Switches capability-trigger report codec to moved chainlink-data-streams/llo/cre.
core/services/llo/cleanup_test.go	Switches mercury transmitter ORM/types import to chainlink-data-streams/mercury/transmitter.
core/services/chainlink/relayer_factory.go	Switches retirement cache import to chainlink-data-streams/llo/retirement.
core/services/chainlink/config_test.go	Updates Mercury protocol constant import to chainlink-data-streams/mercury/transmitter.
core/services/chainlink/config_mercury.go	Updates MercuryTransmitter.Protocol() return type to moved protocol type.
core/services/chainlink/application.go	Switches retirement cache import to chainlink-data-streams/llo/retirement.
core/internal/cltest/cltest.go	Switches retirement cache import to chainlink-data-streams/llo/retirement.
core/config/toml/types.go	Changes MercuryTransmitter.Protocol field type to moved protocol type.
core/config/mercury_config.go	Removes in-repo protocol type/UnmarshalText; uses moved protocol type in interface.
core/cmd/shell.go	Switches retirement cache import to chainlink-data-streams/llo/retirement.
core/capabilities/integration_tests/keystone/llo_feed_test.go	Switches llo/cre import to moved chainlink-data-streams/llo/cre.
core/services/llo/transmitter.go	Removed (moved to chainlink-data-streams).
core/services/llo/retirement/retirement_report_orm.go	Removed (moved to chainlink-data-streams).
core/services/llo/retirement/retirement_report_orm_test.go	Removed alongside moved retirement ORM.
core/services/llo/retirement/retirement_report_cache.go	Removed (moved to chainlink-data-streams).
core/services/llo/retirement/retirement_report_cache_test.go	Removed alongside moved retirement cache.
core/services/llo/retirement/plugin_scoped_retirement_report_cache.go	Removed (moved to chainlink-data-streams).
core/services/llo/retirement/plugin_scoped_retirement_report_cache_test.go	Removed alongside moved plugin-scoped cache.
core/services/llo/retirement/null_retirement_report_cache.go	Removed (moved to chainlink-data-streams or no longer needed).
core/services/llo/retirement/never_retire_cache.go	Removed (moved to chainlink-data-streams).
core/services/llo/mercurytransmitter/transmitter.go	Removed (moved to chainlink-data-streams).
core/services/llo/mercurytransmitter/server.go	Removed alongside moved mercury transmitter implementation.
core/services/llo/mercurytransmitter/queue.go	Removed alongside moved mercury transmitter implementation.
core/services/llo/mercurytransmitter/queue_test.go	Removed alongside moved mercury transmitter implementation.
core/services/llo/mercurytransmitter/persistence_manager.go	Removed alongside moved mercury transmitter implementation.
core/services/llo/mercurytransmitter/persistence_manager_test.go	Removed alongside moved mercury transmitter implementation.
core/services/llo/mercurytransmitter/orm.go	Removed alongside moved mercury transmitter implementation.
core/services/llo/mercurytransmitter/orm_test.go	Removed alongside moved mercury transmitter implementation.
core/services/llo/mercurytransmitter/helpers_test.go	Removed alongside moved mercury transmitter implementation.
core/services/llo/cre/transmitter.go	Removed (moved to chainlink-data-streams).
core/services/llo/cre/transmitter_test.go	Removed alongside moved CRE transmitter.
core/services/llo/cre/report_codec.go	Removed alongside moved CRE report codec.
core/services/llo/bm/dummy_transmitter.go	Removed (moved to chainlink-data-streams).
core/services/llo/bm/dummy_transmitter_test.go	Removed alongside moved bm transmitter.
core/capabilities/streams/types.go	Removed unused local streams trigger config types.

Comments suppressed due to low confidence (6)

core/services/ocr2/plugins/llo/integration_test.go:713

• new(transmitter.MercuryTransmitterProtocolGRPC) is invalid if MercuryTransmitterProtocolGRPC is a constant/value (and will fail to compile). Use a pointer to a value (via a helper like ptr(...), or a local variable) when setting c.Mercury.Transmitter.Protocol.
  core/services/ocr2/plugins/llo/integration_test.go:1486
• new(transmitter.MercuryTransmitterProtocolGRPC) will not compile if MercuryTransmitterProtocolGRPC is a constant/value. Use a pointer to the value (helper like ptr(...), or assign to a local and take &local) when setting c.Mercury.Transmitter.Protocol.
  core/services/ocr2/plugins/llo/integration_test.go:1712
• new(transmitter.MercuryTransmitterProtocolGRPC) is not valid for a constant/value and will break compilation. Use a pointer to a value (e.g., ptr(...) or p := transmitter.MercuryTransmitterProtocolGRPC; c.Mercury.Transmitter.Protocol = &p).
  core/services/ocr2/plugins/llo/integration_test.go:1866
• new(transmitter.MercuryTransmitterProtocolGRPC) will fail to compile if MercuryTransmitterProtocolGRPC is a constant/value. Use a pointer-to-value approach (helper like ptr(...) or a local var) when setting c.Mercury.Transmitter.Protocol.
  core/services/ocr2/plugins/llo/integration_test.go:2226
• new(transmitter.MercuryTransmitterProtocolGRPC) is invalid for a constant/value and will not compile. Use a pointer to a value (via ptr(...) or a local variable) when setting c.Mercury.Transmitter.Protocol.
  core/services/ocr2/plugins/llo/integration_test.go:2733
• new(transmitter.MercuryTransmitterProtocolGRPC) is invalid for a constant/value and will fail compilation. Use a pointer to the protocol value (helper like ptr(...) or assign to local and take address) when setting c.Mercury.Transmitter.Protocol.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[trunk-io]

     

Failed Test	Failure Summary	Logs
TestAddAndPromoteCandidatesForNewChain/Remote_chains_owned_by_MCMS	The test failed without a specific error message, indicating an unspecified failure during the deployment and configuration process.	Logs ↗︎
TestAddAndPromoteCandidatesForNewChain	The test failed without a specific error message, indicating an unspecified failure during the test execution.	Logs ↗︎

View Full Report ↗︎ ⋅ Docs