Vault refactor to support jwt auth and allowlist auth based ownership model#22525
Open
prashantkumar1982 wants to merge 17 commits into
Open
Vault refactor to support jwt auth and allowlist auth based ownership model#22525prashantkumar1982 wants to merge 17 commits into
prashantkumar1982 wants to merge 17 commits into
Conversation
Contributor
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
… into vault-owner-refactor
Trigger CI. Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
product-security-plaid-production
Bot
requested review from
MStreet3,
ecPablo and
pavel-raykov
pavel-raykov
previously approved these changes
May 19, 2026
russell-stern
previously approved these changes
May 20, 2026
jmank88
reviewed
May 20, 2026
Comment on lines
+233
to
+240
| nodeTenantID, errTenant := cresettings.Default.TenantID.GetOrDefault(ctx, v.limitsFactory.Settings) | ||
| if errTenant != nil { | ||
| v.lggr.Errorw("failed to resolve CRE TenantID setting", "method", req.Method, "requestID", req.ID, "error", errTenant) | ||
| return nil, fmt.Errorf("failed to resolve TenantID from CRE settings: %w", errTenant) | ||
| } | ||
| if claims.TenantID != nodeTenantID { | ||
| v.lggr.Debugw("JWT tenant id does not match node TenantID CRE setting", "method", req.Method, "requestID", req.ID, "orgID", claims.OrgID, "claimsTenantID", claims.TenantID, "nodeTenantID", nodeTenantID) | ||
| return nil, fmt.Errorf("%w: jwt tenant id %d node tenant id %d", ErrJWTTenantIDCresettingsMismatch, claims.TenantID, nodeTenantID) |
Contributor
There was a problem hiding this comment.
It would be possible to add a type of limiter that does an equality check, though it wouldn't fit right with the numeric metrics code, so probably not worth pursuing unless we need to rely on those errors types.
|
prashantkumar1982
changed the title
timothyF95
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design: Vault DON design doc (new) — JWT behavior, tenant semantics, and workflow-owner derivation.
This PR implements the job-spec and runtime wiring for that model. Below is repository-specific detail (paths, deployment helpers, tests); the doc remains the authoritative design reference.
Requires smartcontractkit/chainlink-common#2068.
Tenant ID from job specs
For Vault JWT,
TenantIDis fetched from job-specauth0, together withissuerURLandaudience:auth0.tenantID→JWTBasedAuthConfig.TenantID.[pluginConfig.auth0]TOMLtenantID(seeworker-vault.tmpl).