Skip to content

Fix multiple bugs in FakeEVMChain simulator#21254

Draft
wentzeld wants to merge 2 commits intodevelopfrom
fix/fake-evm-chain-additional-bugs
Draft

Fix multiple bugs in FakeEVMChain simulator#21254
wentzeld wants to merge 2 commits intodevelopfrom
fix/fake-evm-chain-additional-bugs

Conversation

@wentzeld
Copy link
Contributor

Summary

  • Fix nil pointer dereference in FilterLogs when converting log topics to protobuf
  • Fix FilterLogs ignoring topics from filter query, and ignoring sign on FromBlock/ToBlock
  • Fix nil pointer in GetTransactionByHash when To() is nil (contract creation txs)
  • Fix GetTransactionReceipt log conversion missing Data and Topics fields
  • Add nil input checks to FilterLogs, EstimateGas, GetTransactionByHash, GetTransactionReceipt (matching existing BalanceAt pattern)

Test plan

  • Verified go build ./core/capabilities/fakes/... compiles cleanly
  • Rebuilt CRE CLI with patched dependency and ran EVM client test workflow exercising all 7 read capabilities

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io
Copy link

trunk-io bot commented Feb 20, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments