Fix nil pointer in FakeEVMChain log conversion#21253
Draft
Fix nil pointer in FakeEVMChain log conversion#21253
Conversation
…tionReceipt FilterLogs was assigning Topics from the uninitialized destination (logsPb[i].Topics) instead of converting the source log.Topics, causing a nil pointer panic. GetTransactionReceipt had the same bug and was also missing Data in its log conversion.
Contributor
|
I see you updated files related to
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Topics: logsPb[i].Topicsread from the uninitialized destination (nil) instead of convertinglog.Topics→ panic on anyfilterLogscall that returns resultsDatafieldTest plan
go mod replacepointing to this fixcre workflow simulatewithfilterLogson historical Sepolia block 10295153 — previously panicked, now returns 1 decoded logsuccessfully