Skip to content

use testing.T.Context()#21252

Merged
jmank88 merged 1 commit intodevelopfrom
test-context
Feb 20, 2026
Merged

use testing.T.Context()#21252
jmank88 merged 1 commit intodevelopfrom
test-context

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Feb 19, 2026

There were 1071 uses of background.Context(). This PR replaces 357 of them with t.Context(), bringing it down to 714.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2026

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

justinkaseman
justinkaseman previously approved these changes Feb 19, 2026
@github-actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

@trunk-io
Copy link

trunk-io bot commented Feb 20, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

pavel-raykov
pavel-raykov previously approved these changes Feb 20, 2026
trunk-io[bot]

This comment was marked as outdated.

@cl-sonarqube-production
Copy link

Copy link

@trunk-io trunk-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Test Results: Unrelated Failure

Affected failures:

  1. Workflow Run: Integration Tests

What Broke

The root cause is a modification in core/capabilities/ccip/oraclecreator/observation_metrics_collector.go that replaced a context cancellation function with a no-op. This prevents proper termination of resources or goroutines associated with the original cancellable context, leading to resource leaks.

Autofix Options

You can use our MCP server to get AI assistance with debugging and fixing these failures.

  • Use MCP in your IDE to debug the issue. Try Help me fix CI failures from wclLaI9b to get started.

View all test uploads

@jmank88 jmank88 added this pull request to the merge queue Feb 20, 2026
Merged via the queue into develop with commit ddc4f25 Feb 20, 2026
316 of 323 checks passed
@jmank88 jmank88 deleted the test-context branch February 20, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments