[NONEVM-3216] Setup coverage reports for timelock/mcms #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricios-space
changed the base branch from
main
to
cicd/provide-source-from-files
patricios-space
force-pushed
the
test/timelock-mcms/coverage
branch
from
0166caa to
6fd46cb
Compare
patricios-space
changed the title
patricios-space
force-pushed
the
test/timelock-mcms/coverage
branch
from
6fd46cb to
206152d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements test coverage reporting for the MCMS (Many Chain Multi-Sig) and RBAC Timelock test suites. The changes refactor test setup to initialize the blockchain once per test suite rather than per test, and add coverage artifact generation hooks.
Key changes:
- Refactored test setup to use
beforeAll/beforeEachpattern with blockchain snapshots for improved performance - Added coverage artifact generation via
afterAllhooks whenCOVERAGEenvironment variable is set - Replaced hardcoded contract IDs with randomly generated ones to avoid collisions
Reviewed changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| RBACTimelockUpdateDelay.spec.ts | Updated to use new test setup pattern and added coverage generation |
| RBACTimelockScheduleBatch.spec.ts | Updated to use new test setup pattern and added coverage generation |
| RBACTimelockReceivable.spec.ts | Updated to use new test setup pattern and added coverage generation |
| RBACTimelockHashing.spec.ts | Updated to use new test setup pattern and added coverage generation |
| RBACTimelockGetters.spec.ts | Updated to use new test setup pattern and added coverage generation |
| RBACTimelockExecuteErrorOracle.spec.ts | Updated to use new test setup pattern, added coverage generation, and switched to random contract IDs |
| RBACTimelockExecute.spec.ts | Updated to use new test setup pattern, added coverage generation, and switched to random contract IDs |
| RBACTimelockConstructor.spec.ts | Updated to use new test setup pattern and added coverage generation |
| RBACTimelockCancel.spec.ts | Updated to use new test setup pattern and added coverage generation |
| RBACTimelockBlockFunction.spec.ts | Updated to use new test setup pattern and added coverage generation |
| RBACTimelock.spec.ts | Moved blockchain initialization to beforeAll, added coverage support, and switched to random contract IDs |
| ManyChainMultiSigSubgroups.spec.ts | Moved blockchain initialization to beforeAll, added coverage support, and switched to random contract IDs |
| ManyChainMultiSigSetRoot.spec.ts | Updated to use new test setup pattern and added coverage generation |
| ManyChainMultiSigSetConfig.spec.ts | Updated to use new test setup pattern, added coverage generation, and improved test data cloning |
| ManyChainMultiSigExecuteErrorOracle.spec.ts | Updated to use new test setup pattern and added coverage generation |
| ManyChainMultiSigExecute.spec.ts | Updated to use new test setup pattern and added coverage generation |
| ManyChainMultiSigDomainSeparation.spec.ts | Updated to use new test setup pattern and added coverage generation |
| ManyChainMultiSigBaseTest.ts | Refactored to support blockchain snapshots, added coverage generation, and implemented new setup patterns |
| MCMS.spec.ts | Moved blockchain initialization to beforeAll, added coverage support, and switched to random contract IDs |
| Integration.spec.ts | Moved blockchain initialization to beforeAll, added coverage support, and switched to random contract IDs |
| BaseTest.ts | Refactored to support blockchain snapshots, added coverage generation, and implemented new setup patterns |
| WithdrawableSpec.ts | Fixed missing await keywords on testDrain function calls |
| OnRamp.setDynamicConfig.spec.ts | Fixed missing await keyword on coverage generation call |
| FeeQuoter.getValidatedFee.spec.ts | Fixed incorrect skip syntax from skip(...) to it.skip(...) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| await baseTest.beforeEach() | ||
| }) | ||
|
|
||
| const cloneTestSigners = (): TestSigner[] => baseTest.testSigners.map((signer) => ({ ...signer })) |
There was a problem hiding this comment.
The cloneTestSigners function creates shallow copies of signers which may cause issues if the signer objects have nested properties that are mutated. Consider making this a method of the base test class where proper deep cloning logic can be centralized.
vicentevieytes
approved these changes
Dec 29, 2025
Collaborator
vicentevieytes
left a comment
vicentevieytes
left a comment
There was a problem hiding this comment.
Thank you for tackling this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NONEVM-3216