Skip to content

Comments

feat: decoder adapter#756

Merged
ChrisAmora merged 1 commit intomainfrom
feat/decoder-adapter
Feb 23, 2026
Merged

feat: decoder adapter#756
ChrisAmora merged 1 commit intomainfrom
feat/decoder-adapter

Conversation

@ChrisAmora
Copy link
Contributor

@ChrisAmora ChrisAmora commented Feb 20, 2026

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2026

⚠️ No Changeset found

Latest commit: ec8aabf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ChrisAmora ChrisAmora marked this pull request as ready for review February 20, 2026 18:10
@cl-sonarqube-production
Copy link

@ChrisAmora ChrisAmora requested a review from a team as a code owner February 20, 2026 18:10
Copilot AI review requested due to automatic review settings February 20, 2026 18:10
@ChrisAmora ChrisAmora marked this pull request as draft February 20, 2026 18:11
@ChrisAmora ChrisAmora marked this pull request as ready for review February 20, 2026 18:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces a decoder adapter that converts experimental analyzer reports into a standardized DecodedTimelockProposal interface. The implementation creates an adapter layer between the experimental analyzer and the proposal analysis engine.

Changes:

  • Implements ExperimentalDecoder that wraps the experimental analyzer's BuildTimelockReport functionality
  • Provides conversion logic to adapt ProposalReport to DecodedTimelockProposal interface
  • Includes comprehensive test coverage for the new decoder and conversion logic

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
decode.go Implements ExperimentalDecoder with proposal validation and report building
decode_test.go Tests for decoder initialization, error handling, and successful decoding
convert.go Conversion logic to adapt experimental analyzer reports to decoder interfaces
convert_test.go Tests for conversion functions including edge cases for method name parsing and field adaptation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ChrisAmora ChrisAmora marked this pull request as draft February 20, 2026 18:20
@ChrisAmora ChrisAmora marked this pull request as ready for review February 23, 2026 13:05
@ChrisAmora ChrisAmora added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit ea7c708 Feb 23, 2026
25 checks passed
@ChrisAmora ChrisAmora deleted the feat/decoder-adapter branch February 23, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants