Skip to content

proposal analyzer: engine wire up#726

Closed
ChrisAmora wants to merge 1 commit intoggoh/mcms-proposal/spike-designfrom
camora/mcms-proposal/spike-design-continuation
Closed

proposal analyzer: engine wire up#726
ChrisAmora wants to merge 1 commit intoggoh/mcms-proposal/spike-designfrom
camora/mcms-proposal/spike-design-continuation

Conversation

@ChrisAmora
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2026

⚠️ No Changeset found

Latest commit: cda80da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

chainutils "github.com/smartcontractkit/chainlink-deployments-framework/chain/utils"
)

func FormatChainLabel(chainSelector uint64, chainName string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like something that should be a part of the renderer/formatter


var _ types.Formatter = (*TextFormatter)(nil)

func (f *TextFormatter) ID() string { return FormatterTextID }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used Claude to create a PoC of a template-based renderer, in case you're interested.

Name() string
Type() string
Value() any
DisplayValue() any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to me this suggests you're mixing business logic with presentation

@ChrisAmora ChrisAmora closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants