Closed
Conversation
📊 API Diff Results
|
bolekk
reviewed
Dec 9, 2025
| } | ||
|
|
||
| // NewAuthorizedStreamsServer creates a server wrapping an authorized capability | ||
| func NewAuthorizedStreamsServer(capability StreamsCapability, authConfig streams.AuthConfig, lggr logger.Logger) (*StreamsServer, error) { |
Contributor
There was a problem hiding this comment.
I don't think we need to handle any authorization here. We will set per-capability limits to 0 by default.
|
|
||
| // Authorizer handles workflow authorization for streams trigger | ||
| // Ensures only authorized workflows (e.g., Data Feeds) can use the trigger | ||
| type Authorizer struct { |
Contributor
There was a problem hiding this comment.
I don't think we need this at all, do we?
|
This PR is stale because it has been open 30 days with no activity. |
…e for equality check
* Move generic chain-agnostic balance monitor to cl-common * gomods tidy * lint * lint * fix typo
…preserve org id (#1744)
…a standard test for it (#1745) * CRE-1613: Fix internal errors passed from WASM host to guest and add a standard test for it * Fix a typo
1. Bump capability concurrency up to 30. Relaying on concurrency limit can cause problems with OCR when different nodes throttle different requests. Let's rely on per-capability limits instead. 2. Reduce consensus call limit to something sane. 3. Reduce trigger event queus size. Usually queueing a lot of events makes them cross the expiration threshold anyway.
* cre-1601: shard orchestrator plugin for delegate * cre-1601: consistent hashing and plugin test * cre-1601: tidy * cre-1601: pb generate * cre-1601: review improvement * cre-1601: review improvement * cre-1601: review improvement * cre-1601: remove previous outcome, use outctx.SeqNr instead * cre-1601: transition state machine * cre-1601: removed TransmissionScheduleOverride * cre-1601: comments * cre-1601: rename plugin to ring * cre-1601: renames and cleanup * cre-1601: delegate integrations adjustments * cre-1601: proto comments; import fix * cre-1601: snake_case consistent for proto fields * cre-1601: remove unused field * cre-1601: more proto comments * cre-1601: proto cleanup, orphans removed * cre-1601: log overrides, log plugin config * cre-1601: better comment * cre-1601: deterministic time; f check for round; improved time median; improved workflows dedup; improved comments; * cre-1601: log improvement * cre-1601: shard count health refactor * cre-1601: hash ring pure function refactor for both storage and observation * cre-1601: Transmitter notifies Arbiter * cre-1601: store in two states, steady and transition; enque for allocation trigger post round; * cre-1601: comments improved * cre-1601: more comments improvements * cre-1601: test extension to validate workflows to shards eassignments * cre-1601: test improvement - distribution check by percents * cre-1601: using maps improvement * cre-1601: remove number of shards limits (ref. review) * cre-1601: initial state fix; intial transition state until OCR round; tests adjustments to simulate state confirmation; * cre-1601: more tests; boosting test coverage * cre-1601: better comments * cre-1601: better comments * cre-1601: improved test for plugin outcome * cre-1601: comments improved * cre-1601: comment improvement * cre-1601: more tests; more coverage * cre-1601: refactor of state; state verification tests; related changes; * cre-1601: bool wrapper ShardStatus to extend with weights later * cre-1601: ArbiterScaler.Status() wantShards being part of the observations in the consensus * cre-1601: improved comments; improved naming; simplified logic; observations validation; ring performance improvements * cre-1601: on 1st round make prior outcome wantShards equal to the current data from the arbiter * cre-1601: removed unnecessary check (code review suggestions) * Fail Observation() on Arbiter error --------- Co-authored-by: Bolek Kulbabinski <1416262+bolekk@users.noreply.github.com>
…ts (#1754) * Add FIFOResourcePoolLimiter to support ordered concurrency limits Almost entirely generated by Claude 4.5 * Merge into the existing resourcePoolLimiter instead of creating a new object
* adding grpc workflow metadata source client and related types * downgrading dependencies to keep diff clean * updating chainlink-protos * bumping protos * bumping protos + PR feedback
* trigger wrapper generator changes to support capability errors * update other trigger capability API errors * update utils to use caperrors.Error * update utils unit test
…1724) * Minor. * Minor.
* Minor. * Minor.
* feat: implement shard-orchestrator logic * chore: use state constants instead of strings * test: add pluging <-> shardorchestrator integration tests * tests: add server tests * feat: add client to communicate with shard 0 * chore: remove unused timestamps * fix: remove reduntant check --------- Co-authored-by: mchain0 <maciej.wisniewski@smartcontract.com>
* Fix CLI embedding * nits
* Minor. * Minor. * Minor. * Minor. * Minor. * Minor. * Minor. --------- Co-authored-by: Connor Stein <connor.stein2@gmail.com>
…rization (handled by CRE per-capability limits)
- Update capability ID to streams-trigger@2.0.0 - Regenerate after proto structure simplification - Remove authorization code (handled by CRE per-capability limits) - Reduces generated code size by ~195 lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.