feat(ui): prefill MCP instructions default + Reset-to-default button (MCP-2484)#686
Closed
Dumbris wants to merge 1 commit into
Closed
feat(ui): prefill MCP instructions default + Reset-to-default button (MCP-2484)#686Dumbris wants to merge 1 commit into
Dumbris wants to merge 1 commit into
Conversation
…(MCP-2484) The Settings "MCP server instructions" textarea previously showed the built-in default only as a placeholder; its editable VALUE was the (empty on a fresh install) config `instructions` field, forcing users who just want to tweak the default to retype the whole thing. - Prefill the editable value with the live `default_instructions` (from /api/v1/status) when the saved `instructions` is empty. Handles either load order (config vs default) and a `watch` so a late default still prefills. Never overwrites a non-empty saved value. - Add a compact "Reset to default" button next to the instructions textarea (shown only once the default has loaded) that repopulates the field from the live default; it flows through the normal change path so Save persists it as `instructions`. Frontend-only — the backend already exposes the resolved default. Related #MCP-2484
Deploying mcpproxy-docs with
|
| Latest commit: |
eef91ce
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://475cbf69.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-mcp-2484-instructions-pr.mcpproxy-docs.pages.dev |
Member
Author
|
Closing as a duplicate of #685 (same MCP-2484 frontend change, created ~5 min earlier and board-announced). #685 is the canonical PR: fuller implementation (whitespace-aware |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Frontend-only UX fix for Settings → "MCP server instructions" (MCP-2484).
Previously the textarea's editable VALUE was the config
instructionsfield (empty on a fresh install) and the built-in default was shown only as a placeholder — a user wanting to tweak/append the default had to retype the whole thing.Changes
default_instructions(from/api/v1/status) when the savedinstructionsis empty. Handles either load order (config vs. default request) plus awatchso a late-arriving default still prefills. Never overwrites a non-empty saved value.instructions.Prefilling-then-saving "freezes" the current default into
config.instructions(intended per the request); the Reset button is the re-sync path. No backend change — the backend already exposes the resolved default.Verification
npx vitest run→ 175 passed (incl. 4 newSettingFieldreset-button tests + existing instructions tests).npm run type-check(vue-tsc) → clean.make build→ frontend embed + Go binaries green.Test plan (added unit coverage)
resetDefaultis injected (async default loaded); hidden otherwise.Related #MCP-2484