fix: correct quarantine API docs and wire tray unquarantine menu#312
Merged
fix: correct quarantine API docs and wire tray unquarantine menu#312
Conversation
Fix B: Documentation showed incorrect curl examples using POST /quarantine
with {"quarantined": false} body. Actual API uses separate POST /quarantine
and POST /unquarantine endpoints with no body. Fixed in rest-api.md,
security-quarantine.md, cli-management-commands.md, and CLAUDE.md.
Fix C: Tray unquarantine menu returned "not yet supported via API". Added
QuarantineServer() and UnquarantineServer() methods to tray API client
and wired adapter to use them. Added 5 tests (27 total pass).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
82aca63
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c39f9f1f.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-quarantine-docs-and-tray.mcpproxy-docs.pages.dev |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 22525666697 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /quarantinewith{"quarantined": false}body. Actual API uses separatePOST /quarantineandPOST /unquarantineendpoints with no request body. Fixed inrest-api.md,security-quarantine.md,cli-management-commands.md, andCLAUDE.md.QuarantineServer()andUnquarantineServer()methods to tray API client and wired the adapter to call them.Changes
docs/api/rest-api.md— split single quarantine entry into two endpointsdocs/features/security-quarantine.md— fixed curl examplesdocs/cli-management-commands.md— fixed curl exampleCLAUDE.md— split quarantine/unquarantine table entrycmd/mcpproxy-tray/internal/api/client.go— added QuarantineServer/UnquarantineServer methodscmd/mcpproxy-tray/internal/api/adapter.go— wired adapter to call actual endpointscmd/mcpproxy-tray/internal/api/adapter_test.go— 5 new tests (27 total pass with -race)Correct API usage
Test plan
go test -race ./cmd/mcpproxy-tray/internal/api/...— 27 tests passgo build ./cmd/mcpproxy-tray/...— compiles🤖 Generated with Claude Code