Fix health calculator suggesting 'login' for offline non-OAuth servers#309
Open
Fix health calculator suggesting 'login' for offline non-OAuth servers#309
Conversation
#242) When an HTTP server goes offline, mcp-go wraps the connection error inside "authentication strategies failed", which caused isOAuthRelatedError() to incorrectly classify it as an OAuth issue. The health calculator then suggested "login" instead of "restart". Fix: check for connection error patterns (connection refused, no such host, dial tcp, i/o timeout, etc.) before checking OAuth patterns in both health/calculator.go and upstream/cli/client.go. Closes #242 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
29ff3da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://72586cef.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-health-calculator-login.mcpproxy-docs.pages.dev |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 22257136038 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isOAuthRelatedError()in bothhealth/calculator.goandupstream/cli/client.goto check for connection errors (connection refused, no such host, dial tcp, etc.) before OAuth patternsrestartinstead ofloginTest plan
loginCloses #242
🤖 Generated with Claude Code