Fix OAuth reconnect loop caused by DCR-only placeholder token#308
Merged
Fix OAuth reconnect loop caused by DCR-only placeholder token#308
Conversation
After logout/restart/login, DCR saves client credentials to storage before token exchange completes. GetToken() returned a non-nil token for these DCR-only records (empty AccessToken, zero ExpiresAt), causing scanForNewTokens() to trigger reconnect loops every 10 seconds. Now GetToken() returns ErrNoToken when AccessToken is empty, consistent with HasPersistedToken() which already checks this correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
8fe86dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://66a297d8.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-oauth-dcr-reconnect-loop.mcpproxy-docs.pages.dev |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 22228614379 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #305.
GetToken()now returnsErrNoTokenwhen the stored record has an emptyAccessToken(DCR-only placeholder)scanForNewTokens()from treating DCR client credentials as a valid persisted token and triggering reconnect loops every 10 secondsRoot Cause
After
logout → restart → login, DCR saves client credentials to BBolt storage before the token exchange completes.GetToken()returned a non-nil*client.Tokenwith emptyAccessTokenand zeroExpiresAtfor these records.scanForNewTokens()only checkedtok != nil, so it continuously triggered reconnects.The existing
HasPersistedToken()helper already checkedrecord.AccessToken != ""correctly —GetToken()now applies the same guard.Test plan
TestGetToken_DCROnlyRecord_ReturnsError)🤖 Generated with Claude Code