fix(release): attach Sparkle enclosures in retry-sign-release - #1363
Merged
Merged
Conversation
v0.69.0 was published by retry-sign-release.yml, whose release job never
downloaded the sparkle-enclosure-* artifacts. The appcast feeds went live
pointing at mcpproxy-0.69.0-darwin-{arm64,amd64}.app.zip, which 404'd, so
every tray auto-update failed with "couldn't download the update".
- release job: download sparkle-enclosure-* (MIN_ASSETS 22 -> 24)
- sparkle-appcast: upload the enclosures together with the feeds, so a
post_release_only run can't publish a feed without its payload
- both workflows: live-feed verification now also checks each feed's
enclosure URL is downloadable
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
51b9662
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6682fc7.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://claude-autoupdater-release-u.mcpproxy-docs.pages.dev |
Dumbris
enabled auto-merge (squash)
September 24, 2026 15:50
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tray auto-update to v0.69.0 failed: "MCPProxy couldn't download the update." The live appcast pointed at
mcpproxy-0.69.0-darwin-{arm64,amd64}.app.zip, but the v0.69.0 release didn't include those files, so the URL returned 404.Root cause: v0.69.0 was published by
retry-sign-release.yml. Itsreleasejob downloads artifacts with explicit patterns and left outsparkle-enclosure-*.release.ymldoesn't hit this because its pattern-lessdownload-artifactpicks the enclosures up.Fix
retry-sign-release.ymlrelease job: downloadsparkle-enclosure-*. Asset floor 22 → 24.retry-sign-release.ymlsparkle-appcast job: upload the enclosures together with the feeds (--clobber), so apost_release_onlyrun can't publish a feed without the file it points to.Remediation already applied
I downloaded both enclosures from release run 35988585835 and checked their length and EdDSA signature against the live feeds and the app's
SUPublicEDKey. Then I uploaded them to v0.69.0. Both URLs now return 200.checksums.txtfor v0.69.0 still doesn't list them; the cosign bundle signs that file, so I left it unchanged.🤖 Generated with Claude Code