Repository navigation
chore: remove the docs sync app secrets from the maintainers guide - #756
Merged
Merged
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
zimeg
marked this pull request as ready for review
November 6, 2026 01:09
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
+ Coverage 78.41% 78.43% +0.01%
==========================================
Files 240 240
Lines 18179 18179
==========================================
+ Hits 14255 14258 +3
+ Misses 3924 3921 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lukegalbraithrussell
approved these changes
Nov 6, 2026
lukegalbraithrussell
left a comment
Contributor
There was a problem hiding this comment.
this takes me back. thank you!
Member
Author
|
🧹 Thanks for the kind review @lukegalbraithrussell! One less stale section to trip over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
N/A. This only changes the maintainers guide.
Summary
This pull request removes the "Synchronizing changes upstream" section from the maintainers guide, along with the
GH_APP_ID_DOCSandGH_APP_PRIVATE_KEY_DOCSsecrets it lists.sync-docs-from-cli-repo.ymlworkflow that used these secrets, so no workflow references them now.[sync]and[github-app-docs]link references. The[sync]link pointed at the deleted workflow file.Preview
N/A
Testing
GH_APP_ID_DOCSandGH_APP_PRIVATE_KEY_DOCSand confirm nothing references them.Notes
The repository secrets themselves are removed separately in settings after merge.
Requirements
🤖 Generated with Claude Code