-
Notifications
You must be signed in to change notification settings - Fork 39
feat: add --force-remote flag to manifest sync #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+49
−1
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
58e107c
feat: add two-way manifest sync between project and app settings
mwbrooks cd86717
Merge remote-tracking branch 'origin/main' into mwbrooks-2-way-manife…
mwbrooks 38f720f
fix: refuse manifest sync when project source is remote
mwbrooks 6f49023
fix: gate manifest sync command behind experiment
mwbrooks f531346
fix: return error on path collisions when unflattening manifests
mwbrooks 52a2fbf
fix: write manifest.json atomically via temp file rename
mwbrooks be92c96
fix: refresh cached manifest hash after sync pushes to app settings
mwbrooks 4dc53cc
fix: honor --force flag in non-TTY manifest sync
mwbrooks faf52bc
fix: surface marshal errors in writeback instead of dropping them
mwbrooks c911ada
fix: surface a warning when manifest.json key order is rewritten
mwbrooks 68ff27e
fix: propagate marshal errors from valuesEqual instead of declaring i…
mwbrooks 49f12f3
fix: escape dots in flattened path segments to preserve dotted keys
mwbrooks c2b199c
Merge remote-tracking branch 'origin/main' into mwbrooks-2-way-manife…
mwbrooks d57b965
chore: add Apache 2.0 license headers to new manifest files
mwbrooks 22e3a29
refactor: move manifest package out of internal/pkg
mwbrooks f4c93e5
Merge remote-tracking branch 'origin/main' into mwbrooks-2-way-manife…
mwbrooks 0da44a8
Merge branch 'main' into mwbrooks-2-way-manifest-sync
srtaalej 0b98837
test: add coverage for manifest sync and display
srtaalej be0f881
test: remove redundant formatValue truncation case
srtaalej 4849b44
feat: add --force-remote flag to manifest sync command
srtaalej 879f3a6
Merge branch 'main' into mwbrooks-2-way-manifest-sync
srtaalej b183197
Merge branch 'mwbrooks-2-way-manifest-sync' into ale-manifest-force-r…
srtaalej f2fc5be
chore: retrigger e2e tests
srtaalej 0c1eae1
fix: resolve merge conflicts with main after PR #591
srtaalej 748326c
Merge branch 'mwbrooks-2-way-manifest-sync' into ale-manifest-force-r…
srtaalej b7e485f
fix: resolve merge conflicts with main
zimeg eeeab35
Merge branch 'main' into ale-manifest-force-remote
zimeg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️🗨️ note: We should avoid adding command flags to these configurations. For now it's alright with suggestions of #543 making it more clear that this is a flag for the
synccommand.👾 ramble: I do find it curious to workaround the flag structures otherwise but fear it blurs concern of what a command can do here.