fix: update SlackListsItemFieldMessage to support single and array message shapes#2627
Open
swayamsingh2004 wants to merge 2 commits into
Open
fix: update SlackListsItemFieldMessage to support single and array message shapes#2627swayamsingh2004 wants to merge 2 commits into
swayamsingh2004 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: f0c9f1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the contribution! Before we can merge this, we need @swayamsingh2004 to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2598
Problem
SlackListsItemFieldMessagetyped themessagefield asstring[], which was incorrect in two ways:messageas either a single object or an array of objectstext,ts, etc.), not stringsSolution
SlackListsItemMessageinterface with optional fields:text,ts,user,team,typemessage: string[]tomessage: SlackListsItemMessage | SlackListsItemMessage[]to handle both shapes the API can returnReferences
SlackListsItem FieldMessage.messagetype does not match API response shape #2598