Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,10 @@ build-backend = "setuptools.build_meta"

[project]
name = "slack_bolt"
dynamic = ["version", "readme", "authors"]
dynamic = ["version", "readme"]
description = "The Bolt Framework for Python"
license = { text = "MIT" }
authors = [{ name = "Slack Technologies, LLC" }, { email = "opensource@slack.com" }]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Splitting authors into a name-only and an email-only entry is a neat trick to keep Author and Author-email exactly as pip show had them. Nice to see setup.cfg go 🧹

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): A short comment above this line explaining the split could stop someone from tidying it into one entry later and bringing back the bug #999 fixed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we need a comment we rarely play in this area

classifiers = [
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
Expand All @@ -26,6 +27,7 @@ dependencies = ["slack_sdk>=3.38.0,<4"]


[project.urls]
Homepage = "https://github.com/slackapi/bolt-python"
Documentation = "https://docs.slack.dev/tools/bolt-python/"
Source = "https://github.com/slackapi/bolt-python"

Expand Down
5 changes: 0 additions & 5 deletions setup.cfg

This file was deleted.

Loading