Skip to content

fix(block-kit): set verbatim false on the card block example text #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwbrooks merged 2 commits into from
Nov 6, 2026
Merged

fix(block-kit): set verbatim false on the card block example text #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f51c568
fix(block-kit): match the card block example to the docs
zimeg Nov 5, 2026
9ae1fb8
Merge branch 'main' into docs-drift-card
zimeg Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions block-kit/src/blocks/card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,21 @@ def example01() -> CardBlock:
"""
block = CardBlock(
icon=ImageElement(image_url="https://picsum.photos/36/36", alt_text="Icon"),
title=MarkdownTextObject(text="Lumon Industries"),
subtitle=MarkdownTextObject(text="Committed to work-life balance"),
title=MarkdownTextObject(
text="Lumon Industries",
verbatim=False,

@mwbrooks mwbrooks Nov 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All three mrkdwn objects match the docs now, with the test covering each one.

),
subtitle=MarkdownTextObject(
text="Committed to work-life balance",
verbatim=False,
),
hero_image=ImageElement(
image_url="https://picsum.photos/400/300", alt_text="Sample hero image"
),
body=MarkdownTextObject(text="Please enjoy each card equally."),
body=MarkdownTextObject(
text="Please enjoy each card equally.",
verbatim=False,
),
actions=[
ButtonElement(
text=PlainTextObject(text="Action Button", emoji=False),
Expand Down
3 changes: 3 additions & 0 deletions block-kit/tests/blocks/test_card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ def test_example01():
"title": {
"type": "mrkdwn",
"text": "Lumon Industries",
"verbatim": False,
},
"subtitle": {
"type": "mrkdwn",
"text": "Committed to work-life balance",
"verbatim": False,
},
"hero_image": {
"type": "image",
Expand All @@ -29,6 +31,7 @@ def test_example01():
"body": {
"type": "mrkdwn",
"text": "Please enjoy each card equally.",
"verbatim": False,
},
"actions": [
{
Expand Down
Loading