Skip to content

fix(block-kit): set verbatim false on the alert block example text - #357

Open
zimeg wants to merge 1 commit into
mainfrom
docs-drift-alert
Open

zimeg wants to merge 1 commit into
mainfrom
docs-drift-alert

Conversation

@zimeg

@zimeg zimeg commented Nov 5, 2026

Copy link
Copy Markdown
Member

Summary

This pull request matches the alert block example to the alert block docs. The docs payload sets text.verbatim to false, and the example and its test left it out.

Changes

  • Test payload: add $.text.verbatim: false
  • Example: pass verbatim=False to the MarkdownTextObject so the example builds the docs payload

The example output now matches the docs JSON field for field. ruff check, ruff format --check, mypy and pytest pass in block-kit. Alert blocks only render in modals and Home tabs, so blocks.validate checked the block in a modal view and returned ok.

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@zimeg zimeg added documentation Improvements or additions to documentation python Pull requests that update python code labels Nov 5, 2026
@zimeg zimeg self-assigned this Nov 5, 2026
@zimeg zimeg changed the title fix(block-kit): match the alert block example to the docs fix(block-kit): set verbatim false on the alert block example text Nov 5, 2026
@zimeg
zimeg marked this pull request as ready for review November 5, 2026 20:28
@zimeg
zimeg requested a review from a team as a code owner November 5, 2026 20:28

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Appreciate this one @zimeg, the alert example now builds exactly the payload the docs show.

Comment thread block-kit/src/blocks/alert.py Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants