Open
Conversation
huyfififi
approved these changes
Aug 10, 2025
| rest = head | ||
|
|
||
| while rest: | ||
| rest_tail = rest.next |
There was a problem hiding this comment.
restとrest_tailが、どちらも「ひっくり返す残りのNodeの末尾」を保持しているように聞こえるのですが、違うNodeを指すことにわかりづらさを覚えました。
line 142時点ではまだひっくり返していないので、next_rest_tail、line 139をrest_tailとした方がわかりやすいのかな？と思います。
There was a problem hiding this comment.
私もこの二つが少しわかりづらいと思いました。
自分はrestをcurrent, rest_tailをsuccessorという名前にしていました。
There was a problem hiding this comment.
参考まで、私は
previous = None
node = headで初期化していました。これだと最終的に previous を返すことになるので好みはあると思いますが、個人的には隣接する node たちを処理しているのがわかってよいかなという感じがしています。
nodchip
reviewed
Aug 11, 2025
| node = head | ||
|
|
||
| while node: | ||
| node_next = node.next |
h1rosaka
reviewed
Aug 12, 2025
| visited_nodes.append(node.val) | ||
| node = node.next | ||
|
|
||
| reversed_head = ListNode(visited_nodes.pop(), None) |
There was a problem hiding this comment.
dummy_headを作って、visited_nodesからpopする処理は全てwhileループの中でやると、似た処理が1箇所にまとまるので、個人的には好きです。
|
読みやすかったです。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
206. Reverse Linked List
次回予告: 283. Move Zeroes