fix(cursor_desktop): support delete on pre-table schemas and KV-only sessions - #57
Open
Adityakk9031 wants to merge 1 commit into
Open
Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
CursorDesktopStore::delete(), the store ran an unconditionalDELETE FROM composerHeaders WHERE composerId = ?1and checked whether any rows were deleted from that table alone.This caused two issues:
composerHeaderstable entirely (whichdiscover()explicitly supports by falling back to scanningcursorDiskKV),delete()failed with a SQLite errorno such table: composerHeaders.composerHeaders, if a session was discovered fromcursorDiskKVwithout an accompanying header entry,delete()cleaned up the KV entries but returnedErr(Error::Malformed("no such session"))becausedeletedfromcomposerHeaderswas 0.This change:
has_table(&conn, "composerHeaders")?before attempting deletion fromcomposerHeaders.Error::Malformedwhen both counts are 0, allowing pre-table databases and KV-only sessions to be deleted cleanly.Testing
delete_roundtrip_removes_session_and_fails_on_duplicate.delete_succeeds_on_database_without_composer_headers_table.delete_succeeds_on_kv_only_session_in_modern_database.cargo test -p txcript --no-default-features --features opencode,hermes,search --test integration cursor_desktop(12/12 passed).cargo clippy -p txcript --no-default-features --features opencode,hermes,search --all-targets -- -D warnings(clean).