Skip to content

fix(registry): reject missing repositories before public SSR - #648

Merged
harlan-zw merged 2 commits into
mainfrom
fix/repo-public-existence
Oct 13, 2026
Merged

harlan-zw merged 2 commits into
mainfrom
fix/repo-public-existence

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Missing Repository URLs return a 200 page and Markdown body when the source API confirms 404.

Read the cached source API before every public Repository response. Keep missing-path alias recovery and lazy Owner profiles for valid browser requests.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent evidence for e11c323:

  • Production reproduction: a missing Repository returns HTML 200 and Markdown 200. Its source API returns 404.
  • The mounted page regression fails before this change and passes after it for a non-bot visitor.
  • Typecheck and lint pass. The focused checks pass 10 tests. The full suite passes 4,020 tests.
  • Valid browser requests read the existing cached source API. Full Owner profiles remain lazy unless alias recovery needs them.

Written by the Harlan Agent Kit agent for this task.

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 13, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 13, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-13 17:00 UTC.

GitHub merged this pull request.

No material findings were recorded.

54238690-f57d-4602-adc7-1b20c06a38f6

@harlan-github-agent harlan-github-agent Bot added harlan-agent-blocked The automated Review found a material defect in this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 13, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: BLOCKED.

Read the Review results

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-blocked The automated Review found a material defect in this head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. labels Oct 13, 2026
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 13, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent fix-forward evidence for fd6ee53:

  • Reproduced the published fixture lint error: two statements on one line. The corrected fixture passes lint.
  • The valid public Repository body and confirmed-missing 404 both pass mounted page checks without a bot identity.
  • Hydration now recognizes the source fetched during SSR, preventing a duplicate source API read.
  • Typecheck, full lint, and fresh lint without generated Nuxt files pass. The focused suite passes 11 tests.
  • The Service Repair stopped because its command host was missing. It changed no files before this fix-forward.

Written by the Harlan Agent Kit agent for this task.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-pending The automated Review is waiting on a gate for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 13, 2026

@harlan-github-agent harlan-github-agent Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-pending The automated Review is waiting on a gate for this head commit. labels Oct 13, 2026
@harlan-zw
harlan-zw merged commit 055fdc2 into main Oct 13, 2026
8 checks passed
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant