Repository navigation
fix(deploy): ship the Harness when it changed since its live commit - #555
Merged
Merged
Conversation
…mmit The harness-proof job compared HEAD^ with HEAD. #550 changed the Harness, then #552 merged and cancelled #550's Test run. The deploy for #552 saw no Harness change, so #550 never reached production until a manual dispatch. Each deploy now tags the version with its commit, and the next main deploy diffs from that commit. Containers roll out at once, so a proof right after a deploy runs the new image.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #550
❓ Type of change
📚 Description
#550 changed the Harness Worker, then #552 merged and cancelled #550's Test run. The
harness-proofjob comparedHEAD^withHEAD, saw only #552, and kept the old version. #550 reached production only through a manual dispatch.Each Harness deploy now tags its Worker version with the commit. The next main deploy reads the live version's commit and diffs it with
HEAD, so a skipped or cancelled run can no longer hide a change. A live version without a tag, or one built from a branch, triggers a deploy of main. Containers now roll out at once, so a proof right after a deploy runs the new image.