Do not report failed iterations as HAR pages without an URL - #2563
Open
soulgalore wants to merge 1 commit into
Open
Do not report failed iterations as HAR pages without an URL#2563soulgalore wants to merge 1 commit into
soulgalore wants to merge 1 commit into
Conversation
When an iteration fails (for example when the BiDi connection to Firefox dies mid test), browsertime adds an empty placeholder HAR so the run count stays intact. That placeholder page has no _url and no entries, so at the end of the run the fully loaded calculation logged a scary "There is an page without an URL in the HAR" error, pointing users at a HAR problem that does not exist. Skip pages without any requests when calculating fully loaded, matching how the main document helpers already handle incomplete pages. Co-authored-by: Claude Fable 5 noreply@anthropic.com Change-Id: I25860ab728d2a4ba6be02efc69074d708968d749
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an iteration fails (for example when the BiDi connection to Firefox dies mid test), browsertime adds an empty placeholder HAR so the run count stays intact. That placeholder page has no _url and no entries, so at the end of the run the fully loaded calculation logged a scary "There is an page without an URL in the HAR" error, pointing users at a HAR problem that does not exist. Skip pages without any requests when calculating fully loaded, matching how the main document helpers already handle incomplete pages.
Co-authored-by: Claude Fable 5 noreply@anthropic.com
Change-Id: I25860ab728d2a4ba6be02efc69074d708968d749