Bug fix - when attributes or filters was None, the string null was sent to the server - #1007
Merged
james-panayis merged 4 commits intoSep 8, 2026
Conversation
Collaborator
Author
|
Also fixing invalid test data used for storage testing. The server now has stricter requirements on the bucket name and region name. |
| attributes=json.dumps(attributes), | ||
| filters=json.dumps(filters), | ||
| attributes=json.dumps(attributes) if attributes is not None else None, | ||
| filters=json.dumps(filters) if filters is not None else None, |
Collaborator
There was a problem hiding this comment.
Doesn't line 275 already guarantee that filters is never None here?
Collaborator
Author
There was a problem hiding this comment.
I hadn't noticed that :-( Attributes was broken (CI tests all fail) and I assumed filters would have the same problem. I've now removed the change involving filters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1005 for more info