Skip to content

test(tools): type the path-safety harnesses instead of erasing with any #7270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Aug 29, 2026
+22 −8
Merged

test(tools): type the path-safety harnesses instead of erasing with any #7270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions apps/sim/tools/daytona/sandbox_path_safety.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import { describe, expect, it } from 'vitest'
import * as daytonaTools from '@/tools/daytona/index'
import { daytonaToolboxUrl, encodeSandboxId } from '@/tools/daytona/utils'
import type { ToolConfig } from '@/tools/types'
import type { ToolConfig, ToolResponse } from '@/tools/types'

const TOOLBOX_PREFIX = '/toolbox/'
const API_PREFIX = '/api/sandbox/'
Expand Down Expand Up @@ -48,7 +48,14 @@ const LEGITIMATE_IDS = [

const SAFE_ID = 'SAFEID'

type AnyTool = ToolConfig<any, any>
/**
* The slice of a tool this harness reads. `ToolConfig`'s param type sits in the
* contravariant position of `request.url`, so no concrete member of the barrel's
* union is assignable to a widened `ToolConfig<Record<string, unknown>, …>`. The
* barrel is therefore seeded as `unknown` below and narrowed by {@link isDaytonaTool},
* which is the single point where the type is established.
*/
type AnyTool = ToolConfig<Record<string, unknown>, ToolResponse>

function isDaytonaTool(value: unknown): value is AnyTool {
return (
Expand Down Expand Up @@ -82,14 +89,14 @@ function buildPath(tool: AnyTool, sandboxId: string): string {
if (typeof url !== 'function') {
throw new Error(`${tool.id} does not build its URL from params`)
}
return new URL(url(buildParams(tool, sandboxId) as any)).pathname
return new URL(url(buildParams(tool, sandboxId))).pathname
}

function segmentsOf(pathname: string): string[] {
return pathname.split('/')
}

const SANDBOX_SCOPED_TOOLS = Object.values(daytonaTools)
const SANDBOX_SCOPED_TOOLS = Object.values<unknown>(daytonaTools)
.filter(isDaytonaTool)
.filter((tool) => typeof tool.request?.url === 'function')
.filter((tool) => {
Expand Down
15 changes: 11 additions & 4 deletions apps/sim/tools/vercel/edge_config_path_safety.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
* output, because string matching is exactly what let this through.
*/
import { describe, expect, it } from 'vitest'
import type { ToolConfig } from '@/tools/types'
import type { ToolConfig, ToolResponse } from '@/tools/types'
import { vercelDeleteEdgeConfigTool } from '@/tools/vercel/delete_edge_config'
import { vercelGetEdgeConfigTool } from '@/tools/vercel/get_edge_config'
import { vercelGetEdgeConfigItemsTool } from '@/tools/vercel/get_edge_config_items'
Expand Down Expand Up @@ -64,7 +64,14 @@ const LEGITIMATE_IDS = [

const SAFE_ID = 'SAFEID'

type AnyTool = ToolConfig<any, any>
/**
* The slice of a tool this harness reads. `ToolConfig`'s param type sits in the
* contravariant position of `request.url`, so no concrete member of the barrel's
* union is assignable to a widened `ToolConfig<Record<string, unknown>, …>`. The
* barrel is therefore seeded as `unknown` below and narrowed by {@link isVercelTool},
* which is the single point where the type is established.
*/
type AnyTool = ToolConfig<Record<string, unknown>, ToolResponse>

function isVercelTool(value: unknown): value is AnyTool {
return (
Expand Down Expand Up @@ -102,14 +109,14 @@ function buildPath(tool: AnyTool, value: string): string {
if (typeof url !== 'function') {
throw new Error(`${tool.id} does not build its URL from params`)
}
return new URL(url(buildParams(tool, value) as any)).pathname
return new URL(url(buildParams(tool, value))).pathname
}

function segmentsOf(pathname: string): string[] {
return pathname.split('/')
}

const DYNAMIC_PATH_TOOLS = Object.values(vercelTools)
const DYNAMIC_PATH_TOOLS = Object.values<unknown>(vercelTools)
.filter(isVercelTool)
.filter((tool) => typeof tool.request?.url === 'function')
.filter((tool) => {
Expand Down
Loading