Skip to content

fix(secrets): preserve caret when revealing values - #7246

Merged
icecrasher321 merged 1 commit into
stagingfrom
codex/fix-secret-field-caret
Aug 29, 2026
Merged

fix(secrets): preserve caret when revealing values#7246
icecrasher321 merged 1 commit into
stagingfrom
codex/fix-secret-field-caret

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve editable secret values in the input while applying visual masking
  • Keep fixed-length placeholders for read-only and withheld secrets
  • Add caret, reveal, editability, and re-mask regression coverage

Type of Change

  • Bug fix

Testing

Targeted secret-value-field Vitest suite, full lint, block registry checks, 39 repository audits, and docs manifest validation.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 29, 2026 12:53am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR preserves editable secret values in the input and applies visual masking while unfocused, avoiding value replacement that moves the caret. It retains fixed-length placeholders for read-only or withheld values and adds focused regression coverage.

  • Uses inputClassName to visually mask editable values without changing the controlled value.
  • Continues using fixed-length bullet masks when the real value must not be placed in the field.
  • Covers caret preservation, reveal permissions, editability, empty values, and remasking after blur.

Confidence Score: 5/5

The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified.

The editable field now retains its controlled value while applying the same visual masking mechanism already used by sibling secret controls, and read-only or withheld values continue to use fixed-length placeholders.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/settings/components/secrets/components/secret-value-field/secret-value-field.tsx Separates editable visual masking from read-only placeholder masking while preserving existing reveal and permission behavior.
apps/sim/app/workspace/[workspaceId]/settings/components/secrets/components/secret-value-field/secret-value-field.test.tsx Updates the ChipInput mock to represent inner-input classes and adds regression coverage for caret preservation and remasking.

Reviews (1): Last reviewed commit: "fix(secrets): preserve caret when reveal..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@icecrasher321
icecrasher321 merged commit 3077553 into staging Aug 29, 2026
27 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-secret-field-caret branch August 29, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants