fix(secrets): preserve caret when revealing values - #7246
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThe PR preserves editable secret values in the input and applies visual masking while unfocused, avoiding value replacement that moves the caret. It retains fixed-length placeholders for read-only or withheld values and adds focused regression coverage.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified. The editable field now retains its controlled value while applying the same visual masking mechanism already used by sibling secret controls, and read-only or withheld values continue to use fixed-length placeholders.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/settings/components/secrets/components/secret-value-field/secret-value-field.tsx | Separates editable visual masking from read-only placeholder masking while preserving existing reveal and permission behavior. |
| apps/sim/app/workspace/[workspaceId]/settings/components/secrets/components/secret-value-field/secret-value-field.test.tsx | Updates the ChipInput mock to represent inner-input classes and adds regression coverage for caret preservation and remasking. |
Reviews (1): Last reviewed commit: "fix(secrets): preserve caret when reveal..." | Re-trigger Greptile
Summary
Type of Change
Testing
Targeted secret-value-field Vitest suite, full lint, block registry checks, 39 repository audits, and docs manifest validation.
Checklist