Skip to content

fix(ui): prevent competing sidebar tooltips - #7235

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-release-overflow-tooltips
Aug 28, 2026
Merged

fix(ui): prevent competing sidebar tooltips#7235
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-release-overflow-tooltips

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • keep the collapsed sidebar tooltip as the sole tooltip owner during expansion transitions
  • remove redundant native workspace-name tooltips when OverflowText owns the full-value tooltip
  • cover both live and loading workspace triggers plus the transition overlap regression

Verification

  • bun run --cwd apps/sim test -- app/workspace/[workspaceId]/w/components/sidebar/components/sidebar-footer/sidebar-footer.test.tsx app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.test.tsx
  • bun run lint:check
  • bun run lint
  • bun run apps/sim/scripts/check-block-registry.ts origin/staging
  • bun run check:audits

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 28, 2026 11:14pm

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR prevents overlapping sidebar tooltips during expansion and removes redundant native workspace-name tooltips.

  • Keeps the collapsed sidebar tooltip authoritative during the expansion transition.
  • Relies on OverflowText for workspace-name overflow tooltips.
  • Adds regression coverage for live, loading, and transition-overlap states.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/sidebar-footer/sidebar-footer.tsx Gates the profile overflow tooltip while the collapsed tooltip still owns the trigger during expansion.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/sidebar-footer/sidebar-footer.test.tsx Adds regression coverage ensuring the overflow tooltip remains disabled during tooltip-ownership overlap.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.tsx Removes native title attributes where workspace labels are already rendered through OverflowText.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.test.tsx Verifies native title attributes are absent from live and loading workspace switcher triggers.

Reviews (2): Last reviewed commit: "fix(ui): prevent competing sidebar toolt..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 force-pushed the codex/fix-release-overflow-tooltips branch from 65ce817 to 4680bd7 Compare August 28, 2026 23:14
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
waleedlatif1 merged commit e9c343d into staging Aug 28, 2026
20 of 21 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-release-overflow-tooltips branch August 28, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant