Skip to content

Fix dark table menu styling - #7233

Closed
waleedlatif1 wants to merge 2 commits into
stagingfrom
codex/fix-resource-header-hover
Closed

Fix dark table menu styling#7233
waleedlatif1 wants to merge 2 commits into
stagingfrom
codex/fix-resource-header-hover

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • preserve the canonical resource-path popover surface while restoring visible dark-mode hover contrast
  • align the table Views popover with EMCN dropdown row geometry, type, spacing, and icon sizing
  • reduce the shared overflow-text fade from 18px to 16px and update its regression coverage and documentation

Validation

  • bun run lint:check
  • bun run check:api-validation
  • bun run --cwd apps/sim type-check
  • bun run --cwd packages/emcn type-check
  • bun run --cwd apps/sim test app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.test.tsx
  • bun run --cwd packages/emcn test src/components/overflow-text/overflow-text.test.tsx
  • verified both menus in the local app in dark mode

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 28, 2026 11:09pm

Request Review

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR aligns the Views popover with the canonical dropdown surface and row styling while improving dark-mode hover contrast. It also reduces the shared overflow-text fade to 16px and updates its documentation and regression coverage.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/components/resource/components/resource-header/resource-header.tsx Adds a dark-mode hover-surface token override to preserve visible hover contrast in the resource-path popover.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.tsx Aligns the Views popover surface, dimensions, rows, spacing, and icons with the canonical dropdown menu treatment.
packages/emcn/src/components/overflow-text/overflow-text.tsx Reduces the shared overflow fade width from 18px to 16px without changing measurement or tooltip behavior.
packages/emcn/src/components/overflow-text/overflow-text.test.tsx Adds regression coverage for the new 16px mask value.
.claude/rules/emcn-components.md Updates the documented OverflowText contract to match the 16px fade implementation.

Reviews (3): Last reviewed commit: "fix: refine views menu composition" | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
waleedlatif1 deleted the codex/fix-resource-header-hover branch August 29, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant