Fix dark table menu styling - #7233
Closed
waleedlatif1 wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR aligns the Views popover with the canonical dropdown surface and row styling while improving dark-mode hover contrast. It also reduces the shared overflow-text fade to 16px and updates its documentation and regression coverage. Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/components/resource/components/resource-header/resource-header.tsx | Adds a dark-mode hover-surface token override to preserve visible hover contrast in the resource-path popover. |
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.tsx | Aligns the Views popover surface, dimensions, rows, spacing, and icons with the canonical dropdown menu treatment. |
| packages/emcn/src/components/overflow-text/overflow-text.tsx | Reduces the shared overflow fade width from 18px to 16px without changing measurement or tooltip behavior. |
| packages/emcn/src/components/overflow-text/overflow-text.test.tsx | Adds regression coverage for the new 16px mask value. |
| .claude/rules/emcn-components.md | Updates the documented OverflowText contract to match the 16px fade implementation. |
Reviews (3): Last reviewed commit: "fix: refine views menu composition" | Re-trigger Greptile
Collaborator
Author
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bun run lint:checkbun run check:api-validationbun run --cwd apps/sim type-checkbun run --cwd packages/emcn type-checkbun run --cwd apps/sim test app/workspace/[workspaceId]/tables/[tableId]/components/views-menu/views-menu.test.tsxbun run --cwd packages/emcn test src/components/overflow-text/overflow-text.test.tsx