fix(executor): preserve actors for actorless tool calls - #7230
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR moves legacy actorless-execution compatibility into the trusted executor principal and removes separate execution-actor inputs from application use cases.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/internal/principals/executor.ts | Binds the execution context user as a compatibility actor only when the trusted executor origin has no Sim-user subject. |
| apps/sim/lib/auth/internal-delegation.ts | Adds validated compatibility-actor binding while rejecting empty actors and delegations that already have a user subject. |
| packages/auth/src/principal.ts | Extends workflow delegation context with a deployment-only compatibility actor and resolves real principal subjects first. |
| apps/sim/lib/credentials/application/authorization.ts | Centralizes credential execution-user resolution through the principal-bound compatibility policy. |
| apps/sim/lib/custom-tools/application/use-cases.ts | Applies principal-derived execution-user scoping consistently to custom-tool reads, listings, updates, and deletes. |
| apps/sim/lib/knowledge/application/billing.ts | Uses the principal-bound execution actor for Knowledge personal-resource and usage attribution paths. |
| apps/sim/lib/mcp/application/authorization.ts | Removes caller-supplied execution identity and resolves MCP credential ownership from the principal. |
| apps/sim/lib/workspace-files/application/share-workspace-file.ts | Preserves actorless deployment sharing behavior through the principal-bound execution actor. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Workflow execution context] --> B[Trusted executor adapter]
B --> C{Principal has Sim user subject?}
C -->|Yes| D[Use authenticated subject]
C -->|No, deployed execution| E[Bind compatibility actor]
D --> F[Principal-based workspace authorization]
E --> F
F --> G[Application operation]
G --> H[Personal resource lookup using execution user]
G --> I[Audit identity using principal]
Reviews (2): Last reviewed commit: "fix(auth): bind legacy execution actors ..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 38 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
TheodoreSpeaks
force-pushed
the
fix/cred-list-require-user
branch
from
August 28, 2026 21:13
5798075 to
53c24fc
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
bun run lintbun run check:auditsbun run type-checkinapps/simChecklist