fix(security): require explicit trust for internal tool routes - #7089
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 118 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
05abbbb to
80abba3
Compare
|
@cubic-dev-ai review this PR |
|
@greptile-apps review this PR |
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
Greptile SummaryThe PR replaces inferred trust for dynamic tool URLs with explicit internal-route policies and validates resolved URLs before request credentials are generated.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/tools/request-transport.ts | Introduces definition-owned route trust and validates internal and external URLs before preparing requests. |
| apps/sim/tools/types.ts | Extends tool request definitions with an explicit static or parameter-dependent internal trust policy. |
| scripts/check-tool-request-boundary.ts | Adds a static audit for missing trust policies and unsafe interpolation in dynamic internal tool routes. |
| apps/sim/tools/request-transport.test.ts | Adds registry-wide probes and focused tests for internal-route canonicalization and external URL restrictions. |
Reviews (4): Last reviewed commit: "fix(tools): validate request trust polic..." | Re-trigger Greptile
|
@greptile-apps review this PR |
There was a problem hiding this comment.
All reported issues were addressed across 118 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
@cubic-dev-ai review this PR |
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
|
@greptile-apps review this PR |
There was a problem hiding this comment.
All reported issues were addressed across 118 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
3326eb2 to
d6654a5
Compare
|
@greptile-apps review this PR |
|
@cubic-dev-ai review this PR |
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
bunx vitest run tools(4,743 passed)bunx vitest run executor/handlers/api/api-handler.test.ts executor/utils/http.test.ts providers/utils.test.ts(184 passed)bun run type-checkbun run lintbun run check:auditsbun run apps/sim/scripts/check-block-registry.ts origin/stagingChecklist