Skip to content

fix(chat): prioritize workflows across resource menus - #7086

Merged
j15z merged 3 commits into
stagingfrom
fix/reorder-mention-menu
Aug 26, 2026
Merged

fix(chat): prioritize workflows across resource menus#7086
j15z merged 3 commits into
stagingfrom
fix/reorder-mention-menu

Conversation

@j15z

@j15z j15z commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Move Workflows above Logs in the shared resource order. This keeps workflows visible when many matching execution logs would otherwise crowd them out in the @ menu, chat composer + menu, and resource-tab + menu.

All pickers continue to use the existing canonical resource comparator. Every other resource type keeps its relative position,

Fixes: N/A (no linked issue)

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

  • Focused Vitest suite for resource matching and ordering: 8 tests passed
  • TypeScript type-checking passed
  • Biome checks passed for the changed files
  • bun run check:api-validation passed
  • Diff-scoped code review completed with no findings
  • Browser QA was not run

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Not included. This is an ordering-only change covered by the focused test suite; browser QA was not run.

Post-Deploy Monitoring & Validation

  • Healthy signal: Workflows appear above Logs in shared resource pickers, while surrounding resource groups retain their existing order.
  • Failure signal: Logs still precede Workflows, or another resource group changes position.
  • Validation window: verify during the first post-release frontend smoke check.
  • Rollback trigger: reproduce an incorrect shared picker order; revert this PR.
  • No additional logs, metrics, or dashboards are needed for this static client-side ordering change.

Compound Engineering

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 26, 2026 1:57am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR moves workflow results directly above execution logs in the chat mention menu while leaving the attachment menu unchanged.

  • Adds a mention-specific workflow-group prioritization helper.
  • Applies the ordering before mention previews and filtered search results are flattened.
  • Adds focused coverage for preserving surrounding resource-group order.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking maintainability issue caused by defining mention ordering outside the shared resource-order configuration.

The changed ordering produces the intended workflow-first mention results without disrupting indexing or selection, but its hard-coded workflow/log splice creates a separate ordering policy that can drift from the central registry.

Files Needing Attention: apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/plus-menu-dropdown/resource-mention-items.ts

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/plus-menu-dropdown/resource-mention-items.ts Adds the intended stable workflow-before-log transformation, but duplicates resource-ordering policy outside the shared registry configuration.
apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/plus-menu-dropdown/plus-menu-dropdown.tsx Applies the transformed group order only in mention mode; filtering, headings, keyboard indexing, and selection remain aligned.
apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/plus-menu-dropdown/resource-mention-items.test.ts Verifies that workflows move immediately above logs without changing surrounding groups' relative order.

Reviews (1): Last reviewed commit: "fix(chat): prioritize workflows in menti..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Centralize mention resource ordering in the registry and derive it from the canonical menu order.
@j15z j15z changed the title fix(chat): prioritize workflows in mention menu fix(chat): prioritize workflows across resource menus Aug 26, 2026
@j15z
j15z merged commit 4caa32c into staging Aug 26, 2026
30 checks passed
@j15z
j15z deleted the fix/reorder-mention-menu branch August 26, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant