improvement(ui): rename user-facing "execution" to "run"#4175
improvement(ui): rename user-facing "execution" to "run"#4175waleedlatif1 wants to merge 22 commits intostagingfrom
Conversation
…ership workflow edits via sockets, ui improvements
…ng improvements, posthog, secrets mutations
…ration, signup method feature flags, SSO improvements
…nts, secrets performance, polling refactors, drag resources in mothership
…y invalidation, HITL docs
…endar triggers, docs updates, integrations/models pages improvements
…ions, jira forms endpoints
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29606901 | Triggered | Generic High Entropy Secret | a54dcbe | apps/sim/providers/utils.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
PR SummaryMedium Risk Overview Cancellation UX fix: Enhances Reviewed by Cursor Bugbot for commit d11832e. Configure here. |
Greptile SummaryThis PR renames user-facing "execution" language to "run" across UI labels, error messages, emails, search suggestions, and docs, while keeping all internal code identifiers (variable names, DB columns, API paths) unchanged. It also adds a direct DB update in the cancel route so the UI reflects Confidence Score: 5/5Safe to merge — all remaining findings are P2 style suggestions with no logic or data-integrity impact. The only functional change (optimistic cancel DB update) is well-guarded by a WHERE status='running' clause, errors are caught and logged without surfacing to the caller, and the new behaviour is covered by four targeted tests. All other changes are user-facing string renames with no logic impact. apps/sim/app/llms.txt/route.ts — the Important Files Changed
Sequence DiagramsequenceDiagram
participant UI
participant CancelRoute as Cancel Route
participant Redis
participant DB as workflowExecutionLogs
participant Executor
UI->>CancelRoute: POST /cancel
CancelRoute->>Redis: markExecutionCancelled(executionId)
Redis-->>CancelRoute: { durablyRecorded: true }
CancelRoute->>DB: UPDATE SET status='cancelled', endedAt=now WHERE executionId=X AND status='running'
DB-->>CancelRoute: OK
CancelRoute-->>UI: { success: true }
Note over UI: UI shows 'cancelled' immediately
Executor->>Executor: detects abort signal
Executor->>DB: safeCompleteWithCancellation() updates endedAt with actual end time
DB-->>Executor: OK
Reviews (1): Last reviewed commit: "improvement(ui): rename user-facing "exe..." | Re-trigger Greptile |
| - **Block**: Individual step such as an LLM call, tool call, HTTP request, or code execution | ||
| - **Trigger**: Event or schedule that initiates workflow execution | ||
| - **Trigger**: Event or schedule that initiates a workflow run | ||
| - **Execution**: A single run of a workflow with logs and outputs |
There was a problem hiding this comment.
"Execution" concept entry not updated
The surrounding entries were updated (Workspace on line 28, Trigger on line 31, and the Capabilities list on line 44), but the **Execution** concept definition still reads "A single run of a workflow" — which internally describes the concept using "run" while the key still says "Execution". This creates an inconsistency in the machine-readable docs file consumed by LLMs.
| - **Execution**: A single run of a workflow with logs and outputs | |
| - **Run**: A single execution of a workflow with logs and outputs |
Summary
Type of Change
Testing
Tested manually
Checklist