Skip to content

improvement(ui): rename user-facing "execution" to "run"#4175

Closed
waleedlatif1 wants to merge 22 commits intostagingfrom
waleedlatif1/execution-to-run-rename
Closed

improvement(ui): rename user-facing "execution" to "run"#4175
waleedlatif1 wants to merge 22 commits intostagingfrom
waleedlatif1/execution-to-run-rename

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Rename all user-facing "execution" language to "run" across app UI, error messages, emails, search suggestions, and docs
  • Add DB transaction to cancel route so UI sees 'cancelled' status immediately
  • Internal code (variable names, types, DB columns, API paths) unchanged

Type of Change

  • Improvement (non-breaking change)

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

waleedlatif1 and others added 22 commits April 3, 2026 23:30
…ership workflow edits via sockets, ui improvements
…ration, signup method feature flags, SSO improvements
* feat(posthog): Add tracking on mothership abort (#4023)

Co-authored-by: Theodore Li <theo@sim.ai>

* fix(login): fix captcha headers for manual login  (#4025)

* fix(signup): fix turnstile key loading

* fix(login): fix captcha header passing

* Catch user already exists, remove login form captcha
…nts, secrets performance, polling refactors, drag resources in mothership
…endar triggers, docs updates, integrations/models pages improvements
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Building Building Preview, Comment Apr 15, 2026 4:37am

Request Review

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Apr 15, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
29606901 Triggered Generic High Entropy Secret a54dcbe apps/sim/providers/utils.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 15, 2026

PR Summary

Medium Risk
Mostly copy/label changes across docs/UI/emails, but it also changes cancellation behavior by directly updating workflowExecutionLogs on cancel to avoid UI flicker; this touches live run-state and could mask edge cases if statuses diverge.

Overview
Terminology shift: Updates user-facing strings across docs, UI, emails, and log search suggestions to prefer “run” over “execution” (e.g., “Run ID”, “Cancel Run”, “Run failed/cancelled”), without changing API paths/IDs.

Cancellation UX fix: Enhances POST /api/workflows/[id]/executions/[executionId]/cancel to optimistically mark workflowExecutionLogs as cancelled (only when the cancellation is durably recorded or locally aborted, and not for paused cancellations), with tests covering the new DB update behavior and failure-tolerant logging.

Reviewed by Cursor Bugbot for commit d11832e. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 15, 2026

Greptile Summary

This PR renames user-facing "execution" language to "run" across UI labels, error messages, emails, search suggestions, and docs, while keeping all internal code identifiers (variable names, DB columns, API paths) unchanged. It also adds a direct DB update in the cancel route so the UI reflects cancelled status immediately without waiting for the executor to finish.

Confidence Score: 5/5

Safe to merge — all remaining findings are P2 style suggestions with no logic or data-integrity impact.

The only functional change (optimistic cancel DB update) is well-guarded by a WHERE status='running' clause, errors are caught and logged without surfacing to the caller, and the new behaviour is covered by four targeted tests. All other changes are user-facing string renames with no logic impact.

apps/sim/app/llms.txt/route.ts — the **Execution** concept entry was not renamed alongside the surrounding entries.

Important Files Changed

Filename Overview
apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.ts Adds an optimistic DB update to mark status as 'cancelled' immediately on the cancel route, so the UI doesn't flicker back to 'running'. Logic is well-guarded: only runs when cancellation was durably recorded or locally aborted (not for paused-execution path), and the WHERE status='running' clause prevents overwriting already-finalized records.
apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.test.ts Adds four tests covering the new DB update behaviour: durably recorded, locally aborted, paused-only (no DB update), and DB failure recovery. Coverage is thorough.
apps/sim/app/llms.txt/route.ts Two entries updated from "executions" to "runs", but the **Execution** concept definition on line 32 was left unchanged, creating a minor inconsistency with the rest of the rename.
apps/sim/lib/logs/execution/logging-session.ts Four error/status messages updated from "Execution" to "Run" terminology; no logic changes.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/utils/workflow-execution-utils.ts Five user-facing strings updated from "Execution" to "Run" in console entries and error messages; no logic changes.
apps/sim/lib/logs/search-suggestions.ts All filter descriptions and suggestion labels updated from "Executions/execution" to "Runs/run"; no logic changes.
apps/sim/components/emails/notifications/workflow-notification-email.tsx Email notification body and button label updated from "execution" to "run" terminology.

Sequence Diagram

sequenceDiagram
    participant UI
    participant CancelRoute as Cancel Route
    participant Redis
    participant DB as workflowExecutionLogs
    participant Executor

    UI->>CancelRoute: POST /cancel
    CancelRoute->>Redis: markExecutionCancelled(executionId)
    Redis-->>CancelRoute: { durablyRecorded: true }
    CancelRoute->>DB: UPDATE SET status='cancelled', endedAt=now WHERE executionId=X AND status='running'
    DB-->>CancelRoute: OK
    CancelRoute-->>UI: { success: true }
    Note over UI: UI shows 'cancelled' immediately

    Executor->>Executor: detects abort signal
    Executor->>DB: safeCompleteWithCancellation() updates endedAt with actual end time
    DB-->>Executor: OK
Loading

Reviews (1): Last reviewed commit: "improvement(ui): rename user-facing "exe..." | Re-trigger Greptile

- **Block**: Individual step such as an LLM call, tool call, HTTP request, or code execution
- **Trigger**: Event or schedule that initiates workflow execution
- **Trigger**: Event or schedule that initiates a workflow run
- **Execution**: A single run of a workflow with logs and outputs
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 "Execution" concept entry not updated

The surrounding entries were updated (Workspace on line 28, Trigger on line 31, and the Capabilities list on line 44), but the **Execution** concept definition still reads "A single run of a workflow" — which internally describes the concept using "run" while the key still says "Execution". This creates an inconsistency in the machine-readable docs file consumed by LLMs.

Suggested change
- **Execution**: A single run of a workflow with logs and outputs
- **Run**: A single execution of a workflow with logs and outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants