feat(mothership): #4090
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| import { db } from '@sim/db' | ||
| import { user } from '@sim/db/schema' | ||
| import { eq } from 'drizzle-orm' | ||
| import { type NextRequest, NextResponse } from 'next/server' | ||
| import { getSession } from '@/lib/auth' | ||
| import { env } from '@/lib/core/config/env' | ||
|
|
||
| const ENV_URLS: Record<string, string | undefined> = { | ||
| dev: env.MOTHERSHIP_DEV_URL, | ||
| staging: env.MOTHERSHIP_STAGING_URL, | ||
| prod: env.MOTHERSHIP_PROD_URL, | ||
| } | ||
|
|
||
| function getMothershipUrl(environment: string): string | null { | ||
| return ENV_URLS[environment] ?? null | ||
| } | ||
|
|
||
| async function isAdminRequestAuthorized() { | ||
| const session = await getSession() | ||
| if (!session?.user?.id) return false | ||
|
|
||
| const [currentUser] = await db | ||
| .select({ role: user.role }) | ||
| .from(user) | ||
| .where(eq(user.id, session.user.id)) | ||
| .limit(1) | ||
|
|
||
| return currentUser?.role === 'admin' | ||
| } | ||
|
|
||
| /** | ||
| * Proxy to the mothership admin API. | ||
| * | ||
| * Query params: | ||
| * env - "dev" | "staging" | "prod" | ||
| * endpoint - the admin endpoint path, e.g. "requests", "licenses", "traces" | ||
| * | ||
| * The request body (for POST) is forwarded as-is. Additional query params | ||
| * (e.g. requestId for GET /traces) are forwarded. | ||
| */ | ||
| export async function POST(req: NextRequest) { | ||
| if (!(await isAdminRequestAuthorized())) { | ||
| return NextResponse.json({ error: 'Unauthorized' }, { status: 401 }) | ||
| } | ||
|
|
||
| const adminKey = env.MOTHERSHIP_API_ADMIN_KEY | ||
| if (!adminKey) { | ||
| return NextResponse.json({ error: 'MOTHERSHIP_API_ADMIN_KEY not configured' }, { status: 500 }) | ||
| } | ||
|
|
||
| const { searchParams } = new URL(req.url) | ||
| const environment = searchParams.get('env') || 'dev' | ||
| const endpoint = searchParams.get('endpoint') | ||
|
|
||
| if (!endpoint) { | ||
| return NextResponse.json({ error: 'endpoint query param required' }, { status: 400 }) | ||
| } | ||
|
|
||
| const baseUrl = getMothershipUrl(environment) | ||
| if (!baseUrl) { | ||
| return NextResponse.json( | ||
| { error: `No URL configured for environment: ${environment}` }, | ||
| { status: 400 } | ||
| ) | ||
| } | ||
|
|
||
| const targetUrl = `${baseUrl}/api/admin/${endpoint}` | ||
|
There was a problem hiding this comment. Endpoint parameter allows path traversal in proxy URLMedium Severity The Additional Locations (1)  Reviewed by Cursor Bugbot for commit 949601c. Configure here. |
||
|
|
||
| try { | ||
| const body = await req.text() | ||
| const upstream = await fetch(targetUrl, { | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| 'x-api-key': adminKey, | ||
| }, | ||
| ...(body ? { body } : {}), | ||
| }) | ||
|
|
||
| const data = await upstream.json() | ||
| return NextResponse.json(data, { status: upstream.status }) | ||
| } catch (error) { | ||
| return NextResponse.json( | ||
| { | ||
| error: `Failed to reach mothership (${environment}): ${error instanceof Error ? error.message : 'Unknown error'}`, | ||
| }, | ||
| { status: 502 } | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| export async function GET(req: NextRequest) { | ||
| if (!(await isAdminRequestAuthorized())) { | ||
| return NextResponse.json({ error: 'Unauthorized' }, { status: 401 }) | ||
| } | ||
|
|
||
| const adminKey = env.MOTHERSHIP_API_ADMIN_KEY | ||
| if (!adminKey) { | ||
| return NextResponse.json({ error: 'MOTHERSHIP_API_ADMIN_KEY not configured' }, { status: 500 }) | ||
| } | ||
|
|
||
| const { searchParams } = new URL(req.url) | ||
| const environment = searchParams.get('env') || 'dev' | ||
| const endpoint = searchParams.get('endpoint') | ||
|
|
||
| if (!endpoint) { | ||
| return NextResponse.json({ error: 'endpoint query param required' }, { status: 400 }) | ||
| } | ||
|
|
||
| const baseUrl = getMothershipUrl(environment) | ||
| if (!baseUrl) { | ||
| return NextResponse.json( | ||
| { error: `No URL configured for environment: ${environment}` }, | ||
| { status: 400 } | ||
| ) | ||
| } | ||
|
|
||
| const forwardParams = new URLSearchParams() | ||
| searchParams.forEach((value, key) => { | ||
| if (key !== 'env' && key !== 'endpoint') { | ||
| forwardParams.set(key, value) | ||
| } | ||
| }) | ||
|
|
||
| const qs = forwardParams.toString() | ||
| const targetUrl = `${baseUrl}/api/admin/${endpoint}${qs ? `?${qs}` : ''}` | ||
|
|
||
| try { | ||
| const upstream = await fetch(targetUrl, { | ||
| method: 'GET', | ||
| headers: { 'x-api-key': adminKey }, | ||
| }) | ||
|
|
||
| const data = await upstream.json() | ||
| return NextResponse.json(data, { status: upstream.status }) | ||
| } catch (error) { | ||
| return NextResponse.json( | ||
| { | ||
| error: `Failed to reach mothership (${environment}): ${error instanceof Error ? error.message : 'Unknown error'}`, | ||
| }, | ||
| { status: 502 } | ||
| ) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev branch skips CI tests before building and deploying
Medium Severity
The
test-buildjob is skipped for pushes to thedevbranch (line 19), andbuild-devonly depends ondetect-version, nottest-build. Combined withmigrate-devrunning migrations after the build, this means untested code gets built into Docker images and database migrations are applied to the dev environment without any test validation.Additional Locations (1)
.github/workflows/ci.yml#L49-L53Reviewed by Cursor Bugbot for commit 949601c. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugbot Autofix determined this is a false positive.
This is intentional design: PRs to dev still run tests (via the pull_request condition), only direct pushes to dev skip tests for faster iteration cycles in the dev environment.
This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.