-
Notifications
You must be signed in to change notification settings - Fork 3.1k
improvement: HITL, subblocks, general #2633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
0db1df1 to
19ff718
Compare
Greptile SummaryRefactored human-in-the-loop (HITL) resume page with improved UI and state management. Updated multiple subblock components (knowledge tag filters, document tags, eval input, starter input format, input mapping, variables input) with consistent styling patterns - standardized spacing from
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant ResumePage
participant API
participant Settings
participant ThemeProvider
Note over User,ThemeProvider: HITL Resume Flow
User->>ResumePage: Access /resume/[workflowId]/[executionId]
ResumePage->>API: GET /api/resume/:workflowId/:executionId
API-->>ResumePage: Return PausedExecutionDetail
ResumePage->>ResumePage: Display pause points & form
User->>ResumePage: Fill form & submit resume
ResumePage->>API: POST /api/resume/:workflowId/:executionId/:contextId
API-->>ResumePage: Resume queued/started
ResumePage->>ResumePage: Update UI state
Note over User,ThemeProvider: General Settings Flow
User->>Settings: Open settings modal
Settings->>Settings: Display profile & preferences
User->>Settings: Click "Landing" button
Settings->>User: Open landing page in new tab
Note over User,ThemeProvider: Theme Changes
ThemeProvider->>ThemeProvider: Set defaultTheme to 'system'
ThemeProvider->>ThemeProvider: Add /resume to landing paths
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12 files reviewed, 1 comment
| --toolbar-triggers-height: 300px; | ||
| --editor-connections-height: 200px; | ||
| --terminal-height: 196px; | ||
| --terminal-height: 155px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: violates custom rule about avoiding globals.css edits - consider moving terminal height to local component styling or CSS variables set via JavaScript
Context Used: Context from dashboard - Avoid editing the globals.css file unless absolutely necessary. Move style changes to local componen... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/_styles/globals.css
Line: 14:14
Comment:
**style:** violates custom rule about avoiding `globals.css` edits - consider moving terminal height to local component styling or CSS variables set via JavaScript
**Context Used:** Context from `dashboard` - Avoid editing the globals.css file unless absolutely necessary. Move style changes to local componen... ([source](https://app.greptile.com/review/custom-context?memory=c3b5e4b0-6580-4307-83aa-ba28f105b3c4))
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Summary
Human in the loop resume page.
Subblocks: knowledge tag, start input, document input, etc.
General settings go back to landing page.
Type of Change
Testing
Solo.
Checklist