Skip to content

Conversation

@emir-karabeg
Copy link
Collaborator

Summary

Human in the loop resume page.

Subblocks: knowledge tag, start input, document input, etc.

General settings go back to landing page.

Type of Change

  • New feature

Testing

Solo.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Dec 30, 2025 1:45am

@emir-karabeg
Copy link
Collaborator Author

@greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 30, 2025

Greptile Summary

Refactored human-in-the-loop (HITL) resume page with improved UI and state management. Updated multiple subblock components (knowledge tag filters, document tags, eval input, starter input format, input mapping, variables input) with consistent styling patterns - standardized spacing from space-y-[4px] to flex flex-col gap-[6px], removed hardcoded dark backgrounds, unified Badge sizing, and applied consistent bg-[var(--surface-4)] header styling. Added "Landing" button to general settings for navigation. Changed theme provider default from 'dark' to 'system' and added /resume path support. Reduced terminal height from 196px to 155px across globals.css, terminal component, and store.

  • Improved HITL resume page layout, form validation, and status handling
  • Standardized subblock component styling and spacing
  • Enhanced theme handling with system preference default
  • Updated terminal height configuration

Confidence Score: 4/5

  • Safe to merge with one minor style guideline violation
  • Code is well-structured with consistent patterns and no functional issues. Single deduction for editing globals.css which violates project style guide
  • apps/sim/app/_styles/globals.css - violates style guide about avoiding globals.css edits

Important Files Changed

Filename Overview
apps/sim/app/_styles/globals.css Updated terminal height from 196px to 155px (violates custom rule c3b5e4b0-6580-4307-83aa-ba28f105b3c4 about avoiding globals.css edits)
apps/sim/app/resume/[workflowId]/[executionId]/resume-page-client.tsx Refactored HITL resume page with improved layout, form handling, and status management
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-modal/components/general/general.tsx Added Landing button to navigate to landing page, adjusted layout and button positioning

Sequence Diagram

sequenceDiagram
    participant User
    participant ResumePage
    participant API
    participant Settings
    participant ThemeProvider
    
    Note over User,ThemeProvider: HITL Resume Flow
    User->>ResumePage: Access /resume/[workflowId]/[executionId]
    ResumePage->>API: GET /api/resume/:workflowId/:executionId
    API-->>ResumePage: Return PausedExecutionDetail
    ResumePage->>ResumePage: Display pause points & form
    User->>ResumePage: Fill form & submit resume
    ResumePage->>API: POST /api/resume/:workflowId/:executionId/:contextId
    API-->>ResumePage: Resume queued/started
    ResumePage->>ResumePage: Update UI state
    
    Note over User,ThemeProvider: General Settings Flow
    User->>Settings: Open settings modal
    Settings->>Settings: Display profile & preferences
    User->>Settings: Click "Landing" button
    Settings->>User: Open landing page in new tab
    
    Note over User,ThemeProvider: Theme Changes
    ThemeProvider->>ThemeProvider: Set defaultTheme to 'system'
    ThemeProvider->>ThemeProvider: Add /resume to landing paths
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

--toolbar-triggers-height: 300px;
--editor-connections-height: 200px;
--terminal-height: 196px;
--terminal-height: 155px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: violates custom rule about avoiding globals.css edits - consider moving terminal height to local component styling or CSS variables set via JavaScript

Context Used: Context from dashboard - Avoid editing the globals.css file unless absolutely necessary. Move style changes to local componen... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/_styles/globals.css
Line: 14:14

Comment:
**style:** violates custom rule about avoiding `globals.css` edits - consider moving terminal height to local component styling or CSS variables set via JavaScript

**Context Used:** Context from `dashboard` - Avoid editing the globals.css file unless absolutely necessary. Move style changes to local componen... ([source](https://app.greptile.com/review/custom-context?memory=c3b5e4b0-6580-4307-83aa-ba28f105b3c4))

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

@emir-karabeg emir-karabeg merged commit e9e5721 into staging Dec 30, 2025
11 checks passed
@emir-karabeg emir-karabeg deleted the improvement/ui branch December 30, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants