fix(billing): don't let a post-commit usage-limit sync failure suppress the seat audit

Cursor Bugbot flagged: reconcileOrganizationSeats committed the seat
change and Stripe outbox enqueue in a transaction, then called
syncSubscriptionUsageLimits outside it before recording the audit/
PostHog events. A thrown sync left a genuinely-changed seat count with
no ORG_SEAT_PROVISIONED/DEPROVISIONED trail. Wrap the sync in its own
try/catch (log + continue) so the events always fire for a committed
change, matching the fire-and-forget instrumentation pattern used
elsewhere in this PR.

Author: waleedlatif1

apps/sim/lib/billing/organizations/seats.test.ts

@@ -1,6 +1,7 @@
 /**
  * @vitest-environment node
  */
+import { auditMock } from '@sim/testing'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { mockSyncSubscriptionUsageLimits, enqueueMock, setMock, queryQueue, mockFeatureFlags } =
@@ -58,6 +59,8 @@ vi.mock('@/lib/core/config/env-flags', () => ({
   },
 }))
 
+vi.mock('@sim/audit', () => auditMock)
+
 import { reconcileOrganizationSeats } from '@/lib/billing/organizations/seats'
 
 const teamSub = {
@@ -101,6 +104,27 @@ describe('reconcileOrganizationSeats', () => {
     )
   })
 
+  it('still records the seat audit when the post-commit usage-limit sync fails', async () => {
+    queryQueue.value = [[teamSub], [{ value: 2 }]]
+    mockSyncSubscriptionUsageLimits.mockRejectedValueOnce(new Error('sync unavailable'))
+
+    const result = await reconcileOrganizationSeats({
+      organizationId: 'org-1',
+      reason: 'member-accepted-invite',
+      actorId: 'user-1',
+    })
+
+    expect(result.changed).toBe(true)
+    expect(setMock).toHaveBeenCalledWith({ seats: 2 })
+    expect(auditMock.recordAudit).toHaveBeenCalledWith(
+      expect.objectContaining({
+        actorId: 'user-1',
+        action: auditMock.AuditAction.ORG_SEAT_PROVISIONED,
+        resourceId: 'org-1',
+      })
+    )
+  })
+
   it('reduces seats to the member count on removal', async () => {
     queryQueue.value = [[{ ...teamSub, seats: 3 }], [{ value: 2 }]]
 

apps/sim/lib/billing/organizations/seats.ts

@@ -136,13 +136,24 @@ export async function reconcileOrganizationSeats({
     return { changed: false, previousSeats: outcome.seats, seats: outcome.seats }
   }
 
-  await syncSubscriptionUsageLimits({
-    id: outcome.sync.id,
-    plan: outcome.sync.plan,
-    referenceId: organizationId,
-    status: outcome.sync.status,
-    seats: outcome.seats,
-  })
+  try {
+    await syncSubscriptionUsageLimits({
+      id: outcome.sync.id,
+      plan: outcome.sync.plan,
+      referenceId: organizationId,
+      status: outcome.sync.status,
+      seats: outcome.seats,
+    })
+  } catch (error) {
+    // Seats already committed in the transaction above; a failure here must not
+    // suppress the audit/analytics events below for a change that already happened.
+    logger.error('Failed to sync usage limits after seat reconciliation', {
+      organizationId,
+      previousSeats: outcome.previousSeats,
+      seats: outcome.seats,
+      error,
+    })
+  }
 
   logger.info('Reconciled organization seats to member count', {
     organizationId,